Skip to content

Commit

Permalink
Fix deployment of branch/commit snapshots
Browse files Browse the repository at this point in the history
Due to a bug (spmjs/node-scp2#21) in the program we are using to ssh snapshots onto streams.spec.whatwg.org, commit and branch snapshots have not been being properly deployed since late October. Fixed this by pinning scp2@0.1.4

Worse, we weren't getting notified of this failure because I was erroneously using Travis CI's `after_success` hook to build and deploy the spec and spec snapshots; if that fails, Travis does not notify you. Fixed by using the `script` hook instead.
  • Loading branch information
domenic committed Dec 12, 2014
1 parent 27b5e16 commit 4567064
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ env:
- secure: "Ga/n9txTxjBDFxsyhbthRZyqVTZA1cOmhH5WaQEWoMcG9yU+RvAdEjqdFmUFHE7SArHIKovyzoupQ9FELESeu8/lkbDtin3MZn3Aj6QXHioBSMihGbduHsGK8yJ1WyjDYXC3fN8XdwNQRZrVFq0ocauPkml/w8uauEsiMo3PX8A="
before_install:
- cd reference-implementation
after_success:
script:
- npm test
- cd ..
- bash ./deploy.sh
3 changes: 2 additions & 1 deletion deploy.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#!/bin/bash
set -e

if [ "$DEPLOY_USER" == "" ]; then
echo "No deploy credentials present; skipping deploy"
Expand Down Expand Up @@ -32,7 +33,7 @@ curl https://api.csswg.org/bikeshed/ -F file=@index.bs > out/index.html;
cp *.svg out

# Install scp2 as a cross-platform scp that supports passwords
npm install -g scp2
npm install -g scp2@0.1.4 # 0.2.0 gives "Error: handle is not a Buffer"

for f in out/*; do
# Deploy to the commit snapshot location
Expand Down

0 comments on commit 4567064

Please sign in to comment.