Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify nonce attribute behavior #5288

Closed
smaug---- opened this issue Feb 13, 2020 · 2 comments · Fixed by #5300
Closed

Clarify nonce attribute behavior #5288

smaug---- opened this issue Feb 13, 2020 · 2 comments · Fixed by #5300
Labels
clarification Standard could be clearer

Comments

@smaug----
Copy link

https://html.spec.whatwg.org/commit-snapshots/344798be98d699dc165e4731c1385781a49a94c8/#nonce-attributes:attr-nonce

extracting the value from the content attribute, moving it into an internal slot named [[CryptographicNonce]]

It is unclear when the relevant "extract" runs. And what the value of the attribute is after that.
@domenic
Copy link
Member

domenic commented Feb 13, 2020

It seems like this is explained a few paragraphs down, once you move from the summary to the normative algorithms. In IRC you seem to have reached the same conclusion, so shall we close this?

@annevk
Copy link
Member

annevk commented Feb 14, 2020

I guess we could clarify a bit that it only happens upon insertion and that modifying the content attribute after insertion does in fact reveal it.

@annevk annevk added the clarification Standard could be clearer label Feb 14, 2020
@annevk annevk changed the title "extracting the value from the content attribute..." Clarify nonce attribute behavior Feb 14, 2020
annevk added a commit that referenced this issue Feb 18, 2020
@annevk
Prevent [[CryptographicNonce]] from being emptied
11482ed 
And also clarify some prose around the nonce content attribute; fixes #5288.
@annevk annevk mentioned this issue Feb 18, 2020
Merged
3 tasks
annevk added a commit that referenced this issue Feb 20, 2020
@annevk
Prevent [[CryptographicNonce]] from being emptied
931ecf4 
Also clarify some prose around the nonce content attribute, including that it does in fact update the slot upon removal.

Tests: web-platform-tests/wpt#21853.

Fixes #5288.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification Standard could be clearer
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent [[CryptographicNonce]] from being emptied whatwg/html
3 participants
@domenic @annevk @smaug----