Make the two ways of event creation share a path #603
Conversation
This introduces the "inner event creation steps" so we don't duplicate a bunch of logic.
|
The main motivation is the ability to add a specification callback here that can be used for custom initialization and also to point out #600 which is rather bad. |
dom.bs
Outdated
| event is signaling. | ||
| <li> | ||
| <p>Let <var>event</var> be the result of running the <a>inner event creation steps</a> with | ||
| <var>eventInterface</var>, <var>realm</var>, the occurrence that the event is signaling, and |
dom.bs
Outdated
| timestamp property of corresponding <code>NSEvent</code> objects. So in this case, the | ||
| {{Event/timeStamp}} value will be equivalent to the <code>NSEvent</code>'s timestamp offset by | ||
| <a>time origin</a>, translated in milliseconds, and with its precision adjusted to meet the | ||
| minimum <a>clock resolution</a>. |
There was a problem hiding this comment.
I'm not sure "translated in(to?) milliseconds, and with its precision adjusted to meet the minimum clock resolution" belongs here anymore, since you moved those specifics down into the inner event creation steps and are now just using an abstract concept of "time". Probably these clauses should be moved down too.
There was a problem hiding this comment.
This in particular is about the occurrence, but I'll see about making it match things a little better.
dom.bs
Outdated
| {{Event/timeStamp}} value will be equivalent to the <code>NSEvent</code>'s timestamp offset by | ||
| <a>time origin</a>, translated in milliseconds, and with its precision adjusted to meet the minimum | ||
| <a>clock resolution</a>. | ||
| <p class=note>For example, in macOS the occurrence time for input actions are available via the |
There was a problem hiding this comment.
...occurrence time for input actions is available via the timestamp property of the corresponding NSEvent object.
(or ...occurrence times for input actions are available via the timestamp property of the corresponding NSEvent objects.)
This introduces the "inner event creation steps" so we don't duplicate a bunch of logic.
Preview | Diff