Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Get Messsage feature in wchat #284

Closed
wants to merge 3 commits into from

Conversation

Rits1272
Copy link
Contributor

@Rits1272 Rits1272 commented Apr 9, 2020

Issue that this pull request solves

Closes: #77

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

Screenshot (61)

Other information

A user can now receive messages in wchat .
The script will be continuously listening to messages from the target. If a message is sent by the target it will be displayed in the terminal. If a user wants to send a message he simply needs to press space bar. After that, the user can send his message.

Initially, @xandao6 suggested using threading. But since asyncio is itself always single-threaded it was no feasible to add a thread. So I came out with this solution.

@Rits1272
Copy link
Contributor Author

Rits1272 commented Apr 9, 2020

Please review @xandao6 @rpotter12 @priyansh19. Sorry for sending PR late. It actually took me a while to come out with the solution.

Copy link
Contributor

@priyansh19 priyansh19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is working fine :)

Copy link
Member

@rpotter12 rpotter12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rits1272 I have tested the changes. I am is receiving messages but not able to send messages.
This script is only receiving messages. Rest all the features is disabled in this.

the screenshot which you have shared is little different from the code. I am not getting any Write your message thing written on my terminal.

@rpotter12 rpotter12 marked this pull request as draft April 9, 2020 18:57
@Rits1272
Copy link
Contributor Author

Rits1272 commented Apr 9, 2020

Hello @rpotter12 I have mentioned in the screenshot as well as in the description if you want to send message you first need to hit spacebar. Kindly check :)

@Rits1272 Rits1272 marked this pull request as ready for review April 9, 2020 21:21
@xandao-dev
Copy link
Collaborator

add keyboard library to setup.py also.

@xandao-dev
Copy link
Collaborator

xandao-dev commented Apr 9, 2020

image
this error occurs when I use manual target select. Ex: "wplay -wc"

@xandao-dev
Copy link
Collaborator

I got a lot of bugs using 'q' to exit,

@rpotter12
Copy link
Member

Hello @rpotter12 I have mentioned in the screenshot as well as in the description if you want to send message you first need to hit spacebar. Kindly check :)

@Ritz1272 I am still not able to send message from your implementation. Please check your implementation again and test it again.

@rpotter12 rpotter12 added gssoc21 medium average issue labels Apr 11, 2020
@Rits1272
Copy link
Contributor Author

  • Manual target select does not give any errors
  • Added keyboard library in the setup.py file
  • Removed the option to exit the terminal chat by pressing q

Please review @rpotter12 @xandao6

@rpotter12
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 4
           

Complexity increasing per file
==============================
- wplay/terminal_chat.py  2
         

Clones removed
==============
+ wplay/terminal_chat.py  -2
         

See the complete overview on Codacy

@rpotter12
Copy link
Member

Screenshot from 2020-04-17 17-15-34

My screenshot doesnot match with your screenshot. write your message (Enter key for breakline) ('.' alone to send message) was not found when I ran the software. I think this was your old screenshot.
I am still not able to send message

@rpotter12 rpotter12 requested a review from xandao-dev April 17, 2020 19:22
@rpotter12 rpotter12 closed this May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc21 medium average issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receive messages in wchat script (Request)
4 participants