-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Get Messsage feature in wchat #284
Conversation
Please review @xandao6 @rpotter12 @priyansh19. Sorry for sending PR late. It actually took me a while to come out with the solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code is working fine :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rits1272 I have tested the changes. I am is receiving messages but not able to send messages.
This script is only receiving messages. Rest all the features is disabled in this.
the screenshot which you have shared is little different from the code. I am not getting any Write your message
thing written on my terminal.
Hello @rpotter12 I have mentioned in the screenshot as well as in the description if you want to send message you first need to hit |
add keyboard library to setup.py also. |
I got a lot of bugs using 'q' to exit, |
@Ritz1272 I am still not able to send message from your implementation. Please check your implementation again and test it again. |
Please review @rpotter12 @xandao6 |
Issues
======
- Added 4
Complexity increasing per file
==============================
- wplay/terminal_chat.py 2
Clones removed
==============
+ wplay/terminal_chat.py -2
See the complete overview on Codacy |
Issue that this pull request solves
Closes: #77
Types of changes
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that applyScreenshots
Other information
A user can now receive messages in
wchat
.The script will be continuously listening to messages from the target. If a message is sent by the target it will be displayed in the terminal. If a user wants to send a message he simply needs to press
space bar
. After that, the user can send his message.Initially, @xandao6 suggested using threading. But since
asyncio
is itself always single-threaded it was no feasible to add a thread. So I came out with this solution.