Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #69

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Update README #69

merged 3 commits into from
Dec 30, 2024

Conversation

phpduy
Copy link
Contributor

@phpduy phpduy commented Dec 18, 2024

No description provided.

mani-apps
mani-apps approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@mani-apps mani-apps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 nice one, nice and simple

@kaytran2992
Copy link
Contributor

Hi @phpduy, Nice one mate.
But could you please update the Gradle file to let the version be dynamic getting the latest of production same as the maven URL tag.

implementation 'com.what3words:w3w-android-ocr-components:$latest'
Thanks

@phpduy phpduy force-pushed the task/MT-7043-Update-README-introducing-new-ways-to-scan-what3words-address-with-W3WImageDataSource branch 2 times, most recently from eaa2a7b to 641e5d2 Compare December 19, 2024 07:03
@phpduy
Copy link
Contributor Author

phpduy commented Dec 19, 2024

@kaytran2992 thanks for your suggestion! But I don't think Markdown itself supports dynamic content directly, unfortunately. However, we already have a Maven Central badge displaying the latest version at the top of the README, so it should be fine. Please correct me if I'm wrong.

@phpduy phpduy force-pushed the task/MT-7043-Update-README-introducing-new-ways-to-scan-what3words-address-with-W3WImageDataSource branch from 641e5d2 to 64b2c2d Compare December 19, 2024 10:38
@phpduy phpduy force-pushed the task/MT-7043-Update-README-introducing-new-ways-to-scan-what3words-address-with-W3WImageDataSource branch from 64b2c2d to e4b727c Compare December 19, 2024 10:40
@phpduy phpduy merged commit 56ba0bb into epic/MT-6551-Define-W3WImageDataSource-in-the-Android-core-library Dec 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaytran2992 kaytran2992 kaytran2992 approved these changes

@mani-apps mani-apps mani-apps approved these changes

@QuocNguyen-w3w QuocNguyen-w3w Awaiting requested review from QuocNguyen-w3w

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phpduy @kaytran2992 @mani-apps