Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix estimateContractGas' error docsPath #991

Closed
wants to merge 1 commit into from
Closed

Conversation

norswap
Copy link
Contributor

@norswap norswap commented Aug 6, 2023

PR-Codex overview

This PR focuses on removing an unused import and updating the storage keys in the call method.

Detailed summary

  • Removed the unused import of getAccount from viem
  • Updated the storage keys in the call method

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Aug 6, 2023

⚠️ No Changeset found

Latest commit: cd5dda0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 6, 2023

@norswap is attempting to deploy a commit to the wagmi Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@tmm tmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changeset with pnpm changeset? Then looks good.

@norswap
Copy link
Contributor Author

norswap commented Aug 6, 2023

Can you add a changeset with pnpm changeset? Then looks good.

Done 👍

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #991 (b863410) into main (f1c32f6) will decrease coverage by 14.42%.
Report is 465 commits behind head on main.
The diff coverage is 85.15%.

❗ Current head b863410 differs from pull request most recent head cd5dda0. Consider uploading reports for the commit cd5dda0 to get more accurate results

@@             Coverage Diff             @@
##             main     #991       +/-   ##
===========================================
- Coverage   99.85%   85.44%   -14.42%     
===========================================
  Files         215      246       +31     
  Lines       12600    25010    +12410     
  Branches     1355     1346        -9     
===========================================
+ Hits        12582    21370     +8788     
- Misses         17     3615     +3598     
- Partials        1       25       +24     
Files Changed Coverage Δ
src/actions/getContract.ts 70.39% <ø> (ø)
src/actions/public/call.ts 59.71% <ø> (-40.29%) ⬇️
src/actions/public/createBlockFilter.ts 72.50% <ø> (-27.50%) ⬇️
src/actions/public/createContractEventFilter.ts 98.78% <ø> (-1.22%) ⬇️
src/actions/public/createEventFilter.ts 100.00% <ø> (ø)
...c/actions/public/createPendingTransactionFilter.ts 100.00% <ø> (ø)
src/actions/public/estimateContractGas.ts 61.00% <ø> (-39.00%) ⬇️
src/actions/public/estimateGas.ts 99.29% <ø> (+0.20%) ⬆️
src/actions/public/getBalance.ts 100.00% <ø> (ø)
src/actions/public/getBlock.ts 93.75% <ø> (-6.25%) ⬇️
... and 16 more

... and 234 files with indirect coverage changes

@jxom
Copy link
Member

jxom commented Aug 7, 2023

Will also need to update snapshots in the test file. Can do this when I get to a computer if you don’t want to go through the ceremony of setting up your environment and running the test suite.

https://github.com/wagmi-dev/viem/blob/main/.github/CONTRIBUTING.md#running-the-test-suite

@jxom
Copy link
Member

jxom commented Aug 8, 2023

Fixed via #1000 (your commit is preserved). Messed up this remote branch lol. Thanks!

@jxom jxom closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants