-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ankr => thirdweb for default rpc urls #3475
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3475 +/- ##
=======================================
Coverage 99.65% 99.66%
=======================================
Files 982 982
Lines 76342 76332 -10
Branches 3306 3306
=======================================
- Hits 76078 76075 -3
+ Misses 241 236 -5
+ Partials 23 21 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
size-limit report 📦
|
Hi, thanks for handling this, any ETA when this might get in and released? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny nit - otherwise 🎉
@@ -31,7 +31,7 @@ const client = createWalletClient({ // [!code focus] | |||
``` | |||
|
|||
:::info | |||
In a production app, it is highly recommended to pass through your authenticated RPC provider URL (Alchemy, Infura, Ankr, etc). If no URL is provided, viem will default to a public RPC provider. [Read more](/docs/clients/transports/http#usage). | |||
In a production app, it is highly recommended to pass through your authenticated RPC provider URL (Alchemy, Infura, Thirdweb, etc). If no URL is provided, viem will default to a public RPC provider. [Read more](/docs/clients/transports/http#usage). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a production app, it is highly recommended to pass through your authenticated RPC provider URL (Alchemy, Infura, Thirdweb, etc). If no URL is provided, viem will default to a public RPC provider. [Read more](/docs/clients/transports/http#usage). | |
In a production app, it is highly recommended to pass through your authenticated RPC provider URL (Alchemy, Infura, thirdweb, etc). If no URL is provided, viem will default to a public RPC provider. [Read more](/docs/clients/transports/http#usage). |
@@ -6,7 +6,7 @@ export const polygonMumbai = /*#__PURE__*/ defineChain({ | |||
nativeCurrency: { name: 'MATIC', symbol: 'MATIC', decimals: 18 }, | |||
rpcUrls: { | |||
default: { | |||
http: ['https://rpc.ankr.com/polygon_mumbai'], | |||
http: ['https://80001.rpc.thirdweb.com'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shut down mumbai btw, so this rpc wont work
After this change, I'm getting cors errors:
|
ankr rugging public rpc urls, thirdweb better anyway
https://x.com/ankr/status/1901666598257401881