Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TransactionReceipt Returns null for l1tol2logs in abs chain #3004

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

atarpara
Copy link
Contributor

@atarpara atarpara commented Nov 13, 2024

On the Abstract Testnet chain, in most recent transactions, l2ToL1Logs may return null.

image


PR-Codex overview

This PR focuses on fixing the TransactionReceipt formatter and type for ZKsync by updating the handling of the l1BatchNumber property to allow for null values.

Detailed summary

  • Updated l1BatchNumber type in src/zksync/types/log.ts to Hex | null.
  • Modified l1BatchNumber handling in src/zksync/formatters.ts to return null if l2ToL1Log.l1BatchNumber is not present.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: 657dc1c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 13, 2024

@atarpara is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@jxom
Copy link
Member

jxom commented Nov 13, 2024

Can you also update the type please?

@atarpara
Copy link
Contributor Author

Can you also update the type please?

Which type??

@jxom
Copy link
Member

jxom commented Nov 15, 2024

The TransactionReceipt type in src/zksync/types/transaction.ts.

@jxom jxom merged commit 0c98d99 into wevm:main Nov 19, 2024
2 of 3 checks passed
This was referenced Nov 19, 2024
@tmm tmm mentioned this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants