Skip to content

Commit

Permalink
[bug] 'an error has ooccured' when saving datasource (apache#5683)
Browse files Browse the repository at this point in the history
The check_ownership was failing when Alpha user was saving a datasource
from the datasource editor.
  • Loading branch information
mistercrunch authored Aug 21, 2018
1 parent 30b5447 commit aea25f0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion superset/views/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ def check_ownership(obj, raise_if_false=True):
if hasattr(orig_obj, 'created_by'):
owners += [orig_obj.created_by]

owner_names = [o.username for o in owners]
owner_names = [o.username for o in owners if o]

if (
g.user and hasattr(g.user, 'username') and
Expand Down
2 changes: 2 additions & 0 deletions superset/views/datasource.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

from flask import request
from flask_appbuilder import expose
from flask_appbuilder.security.decorators import has_access_api
from flask_babel import gettext as __

from superset import appbuilder, db
Expand All @@ -19,6 +20,7 @@
class Datasource(BaseSupersetView):
"""Datasource-related views"""
@expose('/save/', methods=['POST'])
@has_access_api
def save(self):
datasource = json.loads(request.form.get('data'))
datasource_id = datasource.get('id')
Expand Down

0 comments on commit aea25f0

Please sign in to comment.