Make the generated package() prettier #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I failed to notice f6f0ab8 meant I had not just made PEP517 the default on python 3, but actually made it the only option. Add a `--no-pep517` flag to permit overriding this default in the other direction. Considered, but rejected: - Using a `BooleanOptionalAction` to unify the two flags (would bump the minimal `argparse` version to 3.8 for marginal gain) - Keep f6f0ab8's defaulting trick for `IS_PY2` at least -- considering we also need to set defaults based on the python version requested, it makes more sense to group their setting all together
PEP517 packages still need the build backend as a `makedepend` -- build+install+wheel are insufficient to build the package. Separate this out from the other `makedepends` to highlight its importance, and share the configuration across PEP517/non-PEP517 builds.
I didn't notice wenLiangcan#30 unconditionally added space between `depends+=()` and the packaging lines in `package()`, even if no dependencies were passed. Thus, eg for `pip2pkgbuild pip` the result is ``` package() { cd "${srcdir}/${_src_folder}" python -m installer --destdir="${pkgdir}" dist/*.whl } ``` where it should be ``` package() { cd "${srcdir}/${_src_folder}" python -m installer --destdir="${pkgdir}" dist/*.whl } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the generated package() prettier
I didn't notice Make unsplit packages unless necessary #30 unconditionally added space between
depends+=()and the packaging lines in
package(), even if no dependencies werepassed.
Thus, eg for
pip2pkgbuild pipthe result iswhere it should be