Issue 1539 #1548
Merged
Issue 1539 #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested changes
Aug 12, 2020
| """ | ||
| allow_list = ['np', 'pd', 'df', 'plt', 'sns', 'tf', 'cv'] |
There was a problem hiding this comment.
We tend to move these values to https://github.com/wemake-services/wemake-python-styleguide/blob/master/wemake_python_styleguide/constants.py
There was a problem hiding this comment.
ok will move them
There was a problem hiding this comment.
@sobolevn You can check the changes now
Codecov Report
@@ Coverage Diff @@
## master #1548 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 105 105
Lines 5382 5384 +2
Branches 1179 1180 +1
=========================================
+ Hits 5382 5384 +2
Continue to review full report at Codecov.
|
sobolevn
approved these changes
Aug 13, 2020
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Checklist
CHANGELOG.mdRelated issues
Closes #1539
Added an allowlist for commonly used aliases/short forms.
🙏 Please, if you or your company is finding wemake-python-styleguide valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/wemake-python-styleguide. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.