Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing attributes and "boolean" type #72

Merged
merged 2 commits into from
Aug 8, 2019
Merged

fix: Add missing attributes and "boolean" type #72

merged 2 commits into from
Aug 8, 2019

Conversation

ffflorian
Copy link
Member

No description provided.

@ffflorian ffflorian changed the title fix: Required attribute, boolean type, readonly fix: Required and readonly attributes, boolean type Aug 8, 2019
@ffflorian ffflorian requested a review from bennycode August 8, 2019 21:44
@ffflorian ffflorian mentioned this pull request Aug 8, 2019
Merged
bennycode
bennycode approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@bennycode bennycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is ok but the PR title can be a little more self explanatory 👍

@ffflorian ffflorian changed the title fix: Required and readonly attributes, boolean type fix: Add missing attributes and "boolean" type Aug 8, 2019
@ffflorian ffflorian merged commit 4c78260 into master Aug 8, 2019
@ffflorian ffflorian deleted the fix/boolean-required branch August 8, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennycode bennycode bennycode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ffflorian @bennycode