Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #7079
Has a method, that's run on the entrypoint of the app, the fetches and stores data in
webapp/.cache/{cacheKey}
.This makes the data available to client and server.
We can then create contexts, hooks etc that use that data, an example is with the toggles, which requires a cookie & querystring lookup to override user values ontop of defaults.
I thought of having it in webpack - but it would either be a hack or a lot of code overhead, and while we're using the
app
custom entry point, I thought we might as well use it.Another reason is that there is talk of an API to do something similar, but saying that, there was talk of that when transpile modules was made.
This is a WIP and I can move all the toggle stuff out to use our current
Toggle
types if we like the general direction.