added a Library Data Link Explorer link in the API toolbar #11454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +106 B (+0.01%) Total Size: 1 MB
ℹ️ View Unchanged
|
rcantin-w
reviewed
Jan 6, 2025
Comment on lines
173
to
176
| <button type="button" style={{ padding: '10px' }}> | ||
| <>🏷️</> | ||
| </button> | ||
| </a> |
There was a problem hiding this comment.
Let's add a label for the button (could be hidden text or aria-label?), also gives us maintainers more context around it.
rcantin-w
reviewed
Jan 6, 2025
There was a problem hiding this comment.
As discussed, we'd ideally only show the link on works pages (maybe a condition that checks the URL route OR some magic done in /pages/works.tsx, unsure how atm but maybe an idea).
Another thing that'd be great would be to prefill the link for it to be https://main.d33vyuqnhij7au.amplifyapp.com?id=[workId], which you could then use to prefill the Input field index using URLSearchParams to get the value. If we did that, as we said, we'd really have to add a label over the input field to clarify what goes there as it currently uses the placeholder to do that, and that wouldn't be displayed (replaced by the work ID). Doing this would remove a step for our colleagues and would probably be appreciated!
|
Great suggestions, @rcantin-w - the changes have been made to the application, so I'm moving the toolbar link to match the expectations above! |
rcantin-w
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a subtle link to the new Library Data Link Explorer onto the API toolbar. Avoids colleagues from saving the temporary Amplify link as a bookmark.
How to test
Ensure you have the toolbar enabled on your local. Click the link, it should open in a new tab (to allow colleagues to go back and forth to the catalogue with ease, rather than refreshing their search).
The application opened should work as normal.
How can we measure success?
Is the 🏷️ link too subtle? Does it match the style of the toolbar to avoid clutter?
Have we considered potential risks?
Prevents overuse of the application, keeps the toolbar tidy, even when in mini mode.