Tidy up some pieces around wellcomecollection.org subdomains #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamieparkinson
approved these changes
Aug 23, 2022
Happy to take suggestions for alternative names! I’d be tempted to split it into a separate repo also. dns? |
|
iirc the different subdirs of |
|
I've opened #325 to track moving this into a separate repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing and why?
Subdomain behaviour should be easier to define; in particular CNAME records for third-party services and redirecting subdomains to wellcomecollection.org.
This is a precursor to an actual breaking change, which will be a separate PR.
terraform plandiffn/a