-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R-SAIGE on bioconda #272
Comments
Hi @matuskosut thank you very much for sharing these conda packages for saige. I've been attempting to run step1 of saige using the step1_fitNULLGLMM.R with optparse R command line parser package; however, I keep receiving segfault errors: " *** caught segfault *** address 0x19, cause 'memory not mapped' " (saige_error.txt |
Hi @hannahpky, thanks for the feedback. Based on the saige_error.txt that you shared it looks like an incompatibility between optparse and r-base version. Could you shared the exact versions of r-optparse and r-base? There is a special hash string that identifies the build number of that version, for example: "r-base 3.6.1 h8900bf8_2". You can get them using these commands in your conda environment:
I think that if we manage to pinpoint the matching version of optparse that we could make it work and perhaps also set a requirement in the package such that it could work for others. EDIT: getting full |
@hannahpky could you maybe try to install lower version of optparse? e.g.:
|
Thanks Matúš - I installed a the lower version of optparse (1.6.2). I no longer receive the following message; however, I am still receiving the same " *** caught segfault *** address 0x19, cause 'memory not mapped'" message.
I included my conda info and list details to help troubleshoot ( |
@hannahpky interesting, I would definitely try r-base=4.0 or check other version of saige, e.g. 0.42 is available. I will try to have a closer look on this, any other info about inputs (types, parameters,..) that you could share? |
I tried r-base=4.0 with r-saige=0.42.1, but received the same error. These are the inputs I've been using: --plinkFile=/vgipiper05/hannah/stuttering/population_analysis/merged/potential_ctrls/selected_controls_taketwo_09092020/ALL_stut_merged_casesmatchedctrls_LDprunednoHLAinv \
--phenoFile=/vgipiper05/hannah/stuttering/population_analysis/merged/potential_ctrls/selected_controls_taketwo_09092020/PHENO.txt \
--phenoCol=STUT \
--covarColList=PC1,PC2,PC3,PC4,PC5,PC6 \
--sampleIDColinphenoFile=IID \
--traitType=binary \
--nThreads=4 \
--LOCO=FALSE \
--outputPrefix=/vgipiper05/hannah/stuttering/population_analysis/merged/potential_ctrls/selected_controls_taketwo_09092020/SAIGE_11162020/Stut_SAIGE_fitNullGLMM```
All the inputs appear to be read-in correctly and then immediately afterward I receive the "*** caught segfault ***
address 0x19, cause 'memory not mapped' " error. |
@hannahpky I have got the new version in, could you try to upgrade or maybe recreate your conda environment such that new version is installed..
|
It works well so I installed saige successfully which I spent two days installing and failed. Thank you a lot |
@Esther19960123 Great! Happy to hear that everything is working well 😊 in case you will encounter any bug feel free to open a new issue a tag me in.. |
Yep, thanks @matuskosut the new r-saige version seems to be working well! I'm no longer receiving segfault errors :) |
Hi @matuskosut, Thank you so much for sharing the bioconda SAIGE!!! Wei |
Works like a charm! Spent several days trying to install this on the cluster that I work on to no avail. However, your bioconda installation was able to get me to all the help messages successfully! Hopefully it runs without a hitch too! |
@alecmchiu awesome! You probably installed |
Hi @matuskosut ,I have followed your steps to install saige. Do you know how to solve this problem? I have been stuck with this package for 1 week, so any help would be appreciated. Thank you! |
Hi @huanghe0220, thanks for reporting. I updated the guide. There was a bigger change in the new version of savvy library. You will need to use
Or you can add it to your existing environment:
|
@weizhou0 @weizhouUMICH does it seem ok to include info about r-saige package in README? I made a Pull request #343 Feel free to comment/change if there is anything off. |
@matuskosut Thanks for your reply. I suppose the saige has been installed successfully. But when I came to step 2 with the example dataset, Best wishes, |
@huanghe0220 is this plain text dosage files being used? If so, you need to use this version |
@matuskosut I think you mean |
@huanghe0220 yes, thanks for correcting. I fixed the version typo in the issue text. I see that your step 2 issue was Could you make an issue for this if you will still have problem? https://github.com/weizhouUMICH/SAIGE/issues/new |
@matuskosut Thanks for your reply. I will make an issue. |
Hi @matuskosut, There seems the query issue for bgen file in the current bioconda version. I wonder whether you used the bgenix version in the /thirdparty folder when you compile SAIGE. If not, that would cause the issue. Thanks! Wei |
Hi @weizhouUMICH, Is this related to issue: #393 ? Were you also able to reproduce? Could it be possible to reproduce with some nonsensitive data? since I don't have access to any datasets. I built bgenix based on same version as in /thirdparty. I was applying the patches that I identified in your repo. I noticed only one that was missing - although I think it is unrelated - but still I rebuilt bgenix and saige and published in conda in case you want to try it. (e.g.: It is possible to also try bgenix separately to isolate the issue: https://anaconda.org/conda-forge/bgenix |
Hi @matuskosut <https://github.com/matuskosut>,
Yes this is related to issue: #393
<#393> ? and another user also
observed the same issue using the bioconda version.
The code of bgen in the third party actually is not the same as the bgenix
library https://anaconda.org/conda-forge/bgenix, because I made some
modifications for querying with variant IDs in the gene-based tests.
If SAIGE was compiled using the bgen code in the thirdparty folder, it
should not have the issue. I just updated the version to 0.45. Would you
mind updating the bioconda version?
Thanks so much for your help! I'm also trying to learn how to build the
bioconda library. :)
Thanks,
Wei
…On Tue, Jan 25, 2022 at 7:32 AM Matúš Košút ***@***.***> wrote:
Hi @weizhouUMICH <https://github.com/weizhouUMICH>,
Is this related to issue: #393
<#393> ? Were you also able
to reproduce? Could it be possible to reproduce with some nonsensitive
data? since I don't have access to any datasets.
I built bgenix based on same version as in /thirdparty. I was applying the
patches that I identified in your repo. I noticed only one that was missing
- although I think it is unrelated - but still I rebuilt bgenix and saige
and published in conda in case you want to try it.
It is possible to also try bgenix separately to isolate the issue:
https://anaconda.org/conda-forge/bgenix
—
Reply to this email directly, view it on GitHub
<#272 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APJSQMU5AHHOQQD56H2OK7DUX2J5XANCNFSM4TRYDF5Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @weizhouUMICH (@weizhou0 ), One thing to explain is the principle from conda-forge and bioconda - the package should contain only one tool/library which is also implied by the rule that there should not be multiple licenses packaged together. So each package has to be built separately and stated clearly as dependency. Hence we have to build bgenix from separate repo. https://github.com/huntdatacenter/rbgen/tree/build-v1.1.4 Let me know in case you spot any difference. I was aware of some of your earlier changes and passed the patches into that branch, plus I was also patching waf to run with python3. Since this problem appeared only now, I think it still might be some other cause. In the meantime conda package for 0.45 was released, check here: https://anaconda.org/bioconda/r-saige |
Hi @matuskosut, We have just released a new version 1.0.0. It no longer depends on the bgen library. It has computational efficiency improvements for both Step 1 and Step 2 for single-variant and set-based tests. We have created a new program github page https://github.com/saigegit/SAIGE with the documentation provided https://saigegit.github.io/SAIGE-doc/ Thanks! |
Hi @weizhou0 @weizhouUMICH and others,
I managed to revise Saige dependencies and build conda packages for Saige (https://anaconda.org/bioconda/r-saige), such that it could make installation as easier as possible.
Guide
You will need bioconda and conda-forge channels (added in this order):
Feel free to try out the new packages and share feedback:
Available versions
Latest version:

r-base=3.6.3
,r-base=4.0
)Plaintext dosage files
r-base=3.6.3
,r-base=4.0.3
)Other versions previously released
r-base=3.5.1
,r-base=3.6.1
,r-base=4.0
)r-base=3.6.1
,r-base=4.0
)r-base=3.6.1
,r-base=4.0
)r-base=3.6.1
,r-base=4.0
)r-base=3.6.3
,r-base=4.0
)r-base=3.6.3
,r-base=4.0
)r-base=3.6.3
,r-base=4.0
)r-base=3.6.3
,r-base=4.0
)To create conda environment with specific R version:
Versions 0.44.0 or older might require
savvy=1.3.0
. You will need to install them as shown in the example above, if you experience this issue:For those installing r-saige with R 3.6.1 I recommend installing lower version of optparse (this doesn't apply for R4.0):
Related
Some of you may also be interested in other packages that were added:
The text was updated successfully, but these errors were encountered: