More test result methods #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
764a6e0 to
ee24df5
Compare
|
CC @Cube707 |
ee24df5 to
f3ee6a3
Compare
13dcd90 to
83268bf
Compare
nice thanks 👍 |
Cube707
reviewed
Jan 14, 2025
Cube707
reviewed
Jan 14, 2025
junitparser/junitparser.py
Outdated
| def result(self, value: Union[FinalResult, List[FinalResult]]): | ||
| # Check typing | ||
| if not (isinstance(value, FinalResult) or | ||
| isinstance(value, list) and all(isinstance(item, FinalResult) for item in value)): |
There was a problem hiding this comment.
I am always unsure how well people know about operator binding order.
So it might be preferable to make the order of operation clear by adding parenthesis around the .. and ..
EnricoMi
commented
Jan 14, 2025
EnricoMi
commented
Jan 14, 2025
Test Results 48 files ± 0 48 suites ±0 3m 23s ⏱️ -1s Results for commit 2b9358c. ± Comparison against base commit 3719033. This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
91c5255 to
1813897
Compare
weiwei
approved these changes
Jan 25, 2025
1813897 to
b28d948
Compare
- Add is_failure and is_error to JUnit TestCase - Add is_rerun and is_flaky to XUnit2 TestCase - Provide access to XUnit2 interim (rerun & flaky) results Co-authored-by: Jan Wille <mail@janwille.de>
Co-authored-by: Jan Wille <mail@janwille.de>
7f4d4fe to
2b9358c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more test state helper methods like
is_failure,is_error,is_rerunandis_flaky. Further, provides easier access to all interim result types (iterating overTestCaseor callinginterim_resultproperty).