Type-hinting for looping over the xml children #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking for `None` should be done explicitly and not by relying on the falsienes of it. This is faster and avoids problems if falsy objects are passed in as an argument.
|
Thanks for your work! I am also looking forward to this. Could this be merged soon please? @weiwei |
EnricoMi
requested changes
Dec 20, 2024
this fixes the elements being detected as type `Any` and users not getting intellisense
020d9d1 to
4e2398e
Compare
A also added it in |
|
in which version will this improvement be included? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
for suite in xmlandfor case in suitewould not detect the proper types forsuiteandcaseand not give intelisense.this fixes the elements being detected as type
Anyand instead the proper type is detected, enableing auto-completeion.