Add CI to this Repo #1
Conversation
| @@ -1,3 +1,3 @@ | |||
| [submodule "semaphore"] | |||
| path = semaphore | |||
| url = git@github.com:kobigurk/semaphore.git | |||
| url = https://github.com/kobigurk/semaphore.git | |||
There was a problem hiding this comment.
Use https so that CI can pull this submodule
| "/build/", | ||
| "/node_modules/", | ||
| "<rootDir>/build/", | ||
| "<rootDir>/node_modules/", |
There was a problem hiding this comment.
This change is required or the tests could not be resolved in Travis CI. The cause is that Travis CI put the project in a /home/travis/build/ directory, which will be ignored by Jest. The <rootDir> token is the standard way to avoid this issue.
| @@ -7,7 +7,7 @@ | |||
| "watch": "tsc --watch", | |||
| "build": "tsc", | |||
| "prepare": "npm run build", | |||
| "test": "./scripts/downloadSnarks.sh && jest", | |||
| "test": "./scripts/downloadSnarks.sh && jest --force-exit", | |||
There was a problem hiding this comment.
Use force-exit arg to silence Jest's complaint.
Jest did not exit one second after the test run has completed.
This usually means that there are asynchronous operations that weren't stopped in your tests. Consider running Jest with `--detectOpenHandles` to troubleshoot this issue.
| @@ -30,7 +30,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "circomlib": "0.0.19", | |||
| "ethers": "4.0.37", | |||
| "ethers": "4.0.43", | |||
There was a problem hiding this comment.
upgrade to fix this issue ethers-io/ethers.js#622
|
Hi CC! Thank you very much for this PR! Having CI is very useful for this library and will help a lot with ensuring quality. I have no preference between Travis or Github Actions. Feel free to pick whichever you think is best and let's merge this :) Yours, Wei Jie |
|
Thanks for the review! Then, let's do the cool kids' way. Give Github Actions a try. The latest commit passes here. |
Hi Wei Jie,
Notified that this is repo has no CI configured yet. Here are two possible CI options, Travis and Github Actions. Both are easy to configure but maybe one is enough, feel free to choose your favorite. Let me know and I'll remove the unused one to make the PR mergeable.