support opentracing & demo #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
suggested changes
Dec 21, 2016
| if (implementations.hasNext()) { | ||
| tracer = implementations.next(); | ||
| LoggerUtil.info("io.opentracing.Tracer load in DefaultTracerFactory, " + tracer.getClass().getSimpleName() | ||
| + " is used as default tracer."); |
There was a problem hiding this comment.
应该在此处判断，如果有超过一个实现，使用NoopTracer
| + " is used as default tracer."); | ||
| } | ||
| } catch (Exception e) { | ||
| LoggerUtil.warn("DefaultTracerFactory load Tracer fail.", e); |
There was a problem hiding this comment.
如果发生任何异常，需要使用NoopTracer，确保tracer不能为空
There was a problem hiding this comment.
|
好像目前版本有CI失败？ |
|
Travis CI有时会失败可能跟docker环境有关，mvn加载依赖类失败了，稍后我看一下 |
wu-sheng
approved these changes
Dec 21, 2016
| @@ -21,6 +21,7 @@ | |||
| <url>https://github.com/weibocom/motan</url> | |||
| <properties> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <opentracing.version>0.20.2</opentracing.version> | |||
|
非常感谢！ |
|
你们相关的图标么？要求黑白的矢量图，https://github.com/opentracing/opentracing.io/blob/master/img/frameworks/django.svg 我可以准备把你们提交到opentracing.io上了。 如果没有图片，也可以用文字。 |
|
好的，我准备一下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support opentracing
实现方式：motan filter SPI。OpenTracingFilter中按OT 的api对server端和client端进行trace处理。
可用通过spirng 配置方式或api方式替换OpenTracingContext中的TracerFactory， 来实现不同tracer的替换。
demo在test classpath下的com.weibo.api.motan.filter.opentracing.zipkin.demo包下，其中server端使用spring配置方式替换具体trace实现，client端通过代码api替换。