support filter MotanCluster.refers before refresh LoadBalance #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9490ff to
8212eb3
Compare
manageHandler.go
Outdated
| } | ||
| err := json.Unmarshal([]byte(configContent), &config) | ||
| if err != nil { | ||
| JSONError(w, "unmarshal request body failed.") |
core/util.go
Outdated
| @@ -194,21 +194,25 @@ func TrimSplit(s string, sep string) []string { | |||
| if sep == "" { | |||
| return strings.Split(s, sep) | |||
| } | |||
| n := strings.Count(s, sep) + 1 | |||
| a := make([]string, n) | |||
| var a []string | |||
| i := 0 | |||
cluster/motanCluster.go
Outdated
| if len(refersAfterFilter) > 0 { | ||
| refers = refersAfterFilter | ||
| } | ||
| vlog.Warningf("empty refers after filter, cluster: %s", m.url.GetIdentityWithRegistry()) |
cluster/motanCluster.go
Outdated
| @@ -405,6 +426,17 @@ func (m *MotanCluster) GetRuntimeInfo() map[string]interface{} { | |||
| return info | |||
| } | |||
|
|
|||
| func (m *MotanCluster) SetRefersFilters(filter RefersFilter) { | |||
There was a problem hiding this comment.
SetRefersFilters -> SetRefersFilter
manageHandler.go
Outdated
| return true | ||
| } | ||
| url := cls.GetURL() | ||
| refersFilters := config.ParseRefersFilters(url) |
There was a problem hiding this comment.
refersFilters 改为 refersFilter
cluster/RefersFilter.go
Outdated
| var rules []RefersFilterConfig | ||
| for _, filter := range list { | ||
| if (filter.Group == "" && filter.Service == "") || // global filter | ||
| (filter.Group != "" && filter.Group == clusterURL.Group) || // match group |
83dda8c to
3d9c4dd
Compare
support filter MotanCluster.refers before refresh LoadBalance support filter MotanCluster.refers before refresh LoadBalance code review code review & bug fix
3d9c4dd to
cf19c6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.