Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Local Service Discovery (BEP14) #48

Merged
merged 2 commits into from
Nov 5, 2020
Merged

Add Local Service Discovery (BEP14) #48

merged 2 commits into from
Nov 5, 2020

Conversation

hicom150
Copy link
Contributor

@hicom150 hicom150 commented Nov 4, 2020

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[x] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)
Add Local Service Discovery (BEP14) support.

Which issue (if any) does this pull request address?
Fixes: #44

Is there anything you'd like reviewers to focus on?

@hicom150 hicom150 requested review from feross and KayleePop November 4, 2020 19:26
Copy link
Member

@feross feross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING WORK! Just one important thing to fix for the browser case. Otherwise, LGTM!

@feross feross merged commit c2cc994 into master Nov 5, 2020
@feross feross deleted the add_lsd branch November 5, 2020 21:10
@feross
Copy link
Member

feross commented Nov 5, 2020

@hicom150 One other thing – can you add bittorrent-lsd to the webtorrent npm organization? I think you can click "Add Package" on this page to do it: https://www.npmjs.com/settings/webtorrent/packages

@feross
Copy link
Member

feross commented Nov 5, 2020

Published as 9.4.0

@feross
Copy link
Member

feross commented Nov 5, 2020

Released in webtorrent 0.111.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support local service discovery BEP 14
2 participants