Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTCIceCandidate.component is still polyfilled using old spec #999

Closed
fippo opened this issue Jul 30, 2019 · 1 comment · Fixed by #1078
Closed

RTCIceCandidate.component is still polyfilled using old spec #999

fippo opened this issue Jul 30, 2019 · 1 comment · Fixed by #1078
Labels
breaking change breaking change that requires a major version bump

Comments

@fippo
Copy link
Member

fippo commented Jul 30, 2019 •
edited
Loading

see otalk/sdp#26
could be fixed independent of the sdp package version bump but would that require a major version bump?
@fippo
Copy link
Member Author

fippo commented Jul 30, 2019 •
edited
Loading

Note that this is currently creating different behaviour in Chrome (which no longer polyfills and therefore has rtp/rtcp components ) and Firefox/Safari (which polyfills the old "1" / "2")

@fippo fippo added the breaking change breaking change that requires a major version bump label May 18, 2020
fippo added a commit that referenced this issue May 6, 2021
@fippo
bump sdp dep
72fc96b 
breaking change since it changes the RTCIceCandidate polyfill of component, see #999
@fippo fippo mentioned this issue May 6, 2021
Merged
fippo added a commit that referenced this issue May 6, 2021
@fippo
bump sdp dep
099e6aa 
breaking change since it changes the RTCIceCandidate polyfill of component, see #999
@fippo fippo mentioned this issue May 6, 2021
Merged
@skanda890 skanda890 mentioned this issue Sep 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change breaking change that requires a major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump sdp dep webrtcHacks/adapter
1 participant
@fippo