-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x feature -> 2.x develop | Updated: permission denied response #242
Merged
themodernpk
merged 168 commits into
2.x-develop
from
2.x-feature/permission-denied-response
Jan 19, 2024
Merged
Changes from all commits
Commits
Show all changes
168 commits
Select commit
Hold shift + click to select a range
01059da
Updated: setup configuration and account page
we-vikram-wri231 59753e3
Updated: env app name to session prefix and session cookie
we-vikram-wri231 f751d53
Updated: rebuild assets
we-vikram-wri231 880270d
Updated: restricted action
we-vikram-wri231 06f45e8
Updated: restricted action in bulk action
we-vikram-wri231 f0a0697
Updated: restricted action
we-vikram-wri231 56e1d4c
Fixed: permission seeds of taxonomy section
we-vikram-wri231 65855d8
Updated: restricted action for bulk action
we-vikram-wri231 5db5249
Updated: Active all logic
we-vikram-wri231 04e11d4
Fixed: role permission active all logic
we-vikram-wri231 fee0a59
Updated: validation and placeholder text
we-vikram-wri231 49948b2
Updated: rebuild assets
we-vikram-wri231 eaf3bac
Updated: language string of label
we-alam-a001 d14427a
Updated: setup configuration and account page
we-vikram-wri231 9def8d7
Updated: env app name to session prefix and session cookie
we-vikram-wri231 7f97cf8
Updated: rebuild assets
we-vikram-wri231 2192d6d
Updated: validation and placeholder text
we-vikram-wri231 a25e661
Updated: rebuild assets
we-vikram-wri231 280e6b3
Merge remote-tracking branch 'origin/2.x-feature/session-fixes' into …
we-vikram-wri231 616a6e8
Updated: localization of dashboard page
we-alam-a001 2e507db
Updated: sidebar menu label extend and dashboard
we-alam-a001 dc686ff
Added: conditional if for language string
we-alam-a001 39accb1
Fixed: login error while language is fr
we-alam-a001 0e7a2c2
Updated: extend controller for label
we-alam-a001 f9aca85
Fixed: to show bold text
we-alam-a001 233ab41
Updated: sidebar menu label extend and dashboard
we-alam-a001 f677137
Merge remote-tracking branch 'origin/2.x-feature/update-dashbaord-loc…
we-alam-a001 ccf53dc
Updated: dashboard language string
we-alam-a001 0b79f93
Removed: unused line
we-alam-a001 cc2a2c5
Updated: restricted action
we-vikram-wri231 c81b95e
Updated: restricted action in bulk action
we-vikram-wri231 5dd3e50
Updated: restricted action
we-vikram-wri231 13fcb46
Fixed: permission seeds of taxonomy section
we-vikram-wri231 39ef299
Updated: restricted action for bulk action
we-vikram-wri231 1cc03d2
Updated: Active all logic
we-vikram-wri231 41c85d3
Fixed: role permission active all logic
we-vikram-wri231 e4d40d4
Merge remote-tracking branch 'origin/2.x-feature/added-restricted-act…
we-vikram-wri231 297c4cf
Updated: view role bulk function
we-vikram-wri231 d81f670
Updated: bulk all condition
we-vikram-wri231 aad4ff7
Updated: roles bulk actions
we-vikram-wri231 14b2e80
Updated: permission denied response
we-vikram-wri231 66185ea
Updated: registrations permission denied response
we-alam-a001 43bf19a
Updated: haspermission param
we-vikram-wri231 2dcdd79
Updated: users permission denied response
we-alam-a001 5389ad0
Updated: all haspermission param
we-alam-a001 8446f86
Updated: permission denied response in roles
we-alam-a001 db9e927
Updated: permission denied response in permissions
we-alam-a001 83634ef
Updated: permission denied response in modules
we-alam-a001 94f05fb
Updated: media permission denied response
we-alam-a001 76a0fd8
Updated: taxonomies permission denied response
we-alam-a001 fe7a98c
Updated: themes permission denied response
we-alam-a001 df57e6f
Updated: advanced permission denied response
we-alam-a001 a5e5224
Updated settings permission denied response
we-alam-a001 6c6de55
Updated: permission denied response
we-alam-a001 233c580
Updated: theme controller
we-alam-a001 d3ea9f7
Updated: permission denied response
we-alam-a001 cc7d5a5
Merge remote-tracking branch 'origin/2.x-feature/permission-denied-re…
we-alam-a001 a62c2e8
Added: functions to get language string
we-alam-a001 020caf0
Added: run migrations and seeders after installed
we-alam-a001 eff4778
Updated: setup stores
we-alam-a001 005149d
Updated: run seeders method
we-alam-a001 c7b313b
Updated: run migrations and seeders after installed
we-alam-a001 bd05184
Updated: function in setup store
we-alam-a001 d87c98f
Added: run seeder functionality in localization
we-alam-a001 b872b31
Added: functions to get language string
we-alam-a001 94ad323
Merge remote-tracking branch 'origin/2.x-feature/generate-language-fi…
we-alam-a001 4330c01
Updated: naming of language strings
we-alam-a001 115e5d1
Updated: permission denied response
we-vikram-wri231 c455a89
Updated: naming convention
we-alam-a001 bf55e0e
Updated: permission denied response
we-alam-a001 2771bf9
Updated: registrations permission response
we-alam-a001 5e54350
Updated: users permission response
we-alam-a001 c667cb2
Updated: themes permission response
we-alam-a001 39bf5c8
Updated: taxonomy permission response
we-alam-a001 53723de
Updated: roles permission response
we-alam-a001 d261d53
Updated: permission denied response of permission
we-alam-a001 097e5d8
Updated: modules permission response
we-alam-a001 264972e
Updated: media permission response
we-alam-a001 84e35e5
Updated: settings permission response
we-alam-a001 fd92d31
Updated: permission response in backup and settings
we-alam-a001 0b10c6c
Updated: advanced permission response
we-alam-a001 945a0ef
Updated: if condition in users actions
we-alam-a001 4cd6c72
Updated: if condition in users form and view
we-alam-a001 d588432
Updated: users assets language string
we-alam-a001 2b70394
Updated: conditions for language string error
we-alam-a001 afe5d1a
Updated: label of extend
we-alam-a001 e045755
Updated: condition when no strings provided
we-alam-a001 3aed7ca
Added: watch for looking store assets loaded
we-alam-a001 d89128d
Updated: users title
we-alam-a001 ff41a29
Merge pull request #241 from webreinvent/2.x-feature/added-restricted…
themodernpk 6cae5b9
Updated: dashboard language strings
we-alam-a001 eeac38b
Fixed: registration not found error message
we-alam-a001 d6024b6
Added: functions to get language string
we-alam-a001 6348105
Added: run migrations and seeders after installed
we-alam-a001 c95e0b6
Updated: setup stores
we-alam-a001 e3ad41e
Updated: run seeders method
we-alam-a001 aa5b7e0
Updated: run migrations and seeders after installed
we-alam-a001 deb8967
Updated: function in setup store
we-alam-a001 899c146
Added: run seeder functionality in localization
we-alam-a001 6048d65
Updated: naming of language strings
we-alam-a001 958d731
Updated: naming convention
we-alam-a001 d3c0c36
Updated: if condition in users actions
we-alam-a001 3ad9956
Updated: if condition in users form and view
we-alam-a001 afc636e
Updated: users assets language string
we-alam-a001 bdf640f
Updated: conditions for language string error
we-alam-a001 9ec4791
Updated: label of extend
we-alam-a001 a5c02fd
Updated: condition when no strings provided
we-alam-a001 5469172
Added: watch for looking store assets loaded
we-alam-a001 a3f672b
Updated: users title
we-alam-a001 1e10a0b
Fixed: registration not found error message
we-alam-a001 6f6239e
Merge remote-tracking branch 'origin/2.x-feature/generate-language-fi…
we-vikram-wri231 4ec900d
Updated: page title strings
we-alam-a001 de3402c
Merge remote-tracking branch 'origin/2.x-feature/generate-language-fi…
we-alam-a001 b8f764f
Updated: style overflow
we-vikram-wri231 25923d0
Merge pull request #244 from webreinvent/2.x-feature/fixx-notificatio…
themodernpk fd0fca6
Merge pull request #243 from webreinvent/2.x-feature/generate-languag…
themodernpk 1882ae5
Updated: language string of label
we-alam-a001 bf5827e
Updated: sidebar menu label extend and dashboard
we-alam-a001 5a0c3ca
Added: conditional if for language string
we-alam-a001 7cc0aa9
Fixed: login error while language is fr
we-alam-a001 4ffe099
Updated: extend controller for label
we-alam-a001 a69b94d
Fixed: to show bold text
we-alam-a001 72ca26a
Updated: dashboard language string
we-alam-a001 cc44817
Removed: unused line
we-alam-a001 91b5abc
Updated: dashboard language strings
we-alam-a001 6f99b4b
Merge remote-tracking branch 'origin/2.x-feature/update-dashbaord-loc…
we-alam-a001 97a2151
Updated: language strings after rebase
we-alam-a001 8f903c9
Merge pull request #239 from webreinvent/2.x-feature/update-dashbaord…
themodernpk b10382d
Updated: setup configuration and account page
we-vikram-wri231 33ab1d8
Updated: env app name to session prefix and session cookie
we-vikram-wri231 764dc90
Updated: rebuild assets
we-vikram-wri231 3a8b164
Updated: validation and placeholder text
we-vikram-wri231 532d568
Updated: rebuild assets
we-vikram-wri231 c4800f2
Updated: setup configuration and account page
we-vikram-wri231 366956d
Updated: rebuild assets
we-vikram-wri231 10fb87c
Updated: validation and placeholder text
we-vikram-wri231 42ea23e
Updated: rebuild assets
we-vikram-wri231 35af503
Merge remote-tracking branch 'origin/2.x-feature/session-fixes' into …
we-vikram-wri231 e9dd125
Merge pull request #233 from webreinvent/2.x-feature/session-fixes
themodernpk d62c411
Updated: permission denied response
we-vikram-wri231 af70ec4
Updated: registrations permission denied response
we-alam-a001 5990e45
Updated: haspermission param
we-vikram-wri231 cd2e021
Updated: users permission denied response
we-alam-a001 5f29150
Updated: all haspermission param
we-alam-a001 d9ede0d
Updated: permission denied response in roles
we-alam-a001 d1807fb
Updated: permission denied response in permissions
we-alam-a001 c8ce3b0
Updated: permission denied response in modules
we-alam-a001 53c0ed5
Updated: media permission denied response
we-alam-a001 db1143a
Updated: taxonomies permission denied response
we-alam-a001 7a75fda
Updated: themes permission denied response
we-alam-a001 cf3fc2e
Updated: advanced permission denied response
we-alam-a001 9ca07d9
Updated settings permission denied response
we-alam-a001 039e95f
Updated: permission denied response
we-alam-a001 07fd740
Updated: theme controller
we-alam-a001 88a3304
Updated: permission denied response
we-vikram-wri231 abcad0f
Updated: permission denied response
we-alam-a001 62f8e84
Updated: registrations permission response
we-alam-a001 9444d8a
Updated: users permission response
we-alam-a001 ad8a72f
Updated: themes permission response
we-alam-a001 f7b8fa8
Updated: taxonomy permission response
we-alam-a001 ca53dac
Updated: roles permission response
we-alam-a001 2e0507f
Updated: permission denied response of permission
we-alam-a001 2787739
Updated: modules permission response
we-alam-a001 f419dde
Updated: media permission response
we-alam-a001 7127d79
Updated: settings permission response
we-alam-a001 c0674e8
Updated: permission response in backup and settings
we-alam-a001 daafd88
Updated: advanced permission response
we-alam-a001 6ce454e
Merge remote-tracking branch 'origin/2.x-feature/permission-denied-re…
we-vikram-wri231 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,11 +15,10 @@ public function __construct() | |
//---------------------------------------------------------- | ||
public function getAssets(Request $request): JsonResponse | ||
{ | ||
if (!Auth::user()->hasPermission('has-access-of-advanced-section')) { | ||
$response['success'] = false; | ||
$response['errors'][] = trans("vaahcms::messages.permission_denied"); | ||
$permission_slug = 'has-access-of-advanced-section'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @we-vikram-wri231 this should be array instead of line number 21, make this change everywhere else as well |
||
|
||
return response()->json($response); | ||
if(!Auth::user()->hasPermission($permission_slug)) { | ||
return vh_get_permission_denied_json_response($permission_slug); | ||
} | ||
|
||
try { | ||
|
@@ -68,11 +67,10 @@ public function getAssets(Request $request): JsonResponse | |
//---------------------------------------------------------- | ||
public function getList(Request $request): JsonResponse | ||
{ | ||
if (!Auth::user()->hasPermission('has-access-of-batches-section')) { | ||
$response['success'] = false; | ||
$response['errors'][] = trans("vaahcms::messages.permission_denied"); | ||
$permission_slug = 'has-access-of-batches-section'; | ||
|
||
return response()->json($response); | ||
if(!Auth::user()->hasPermission($permission_slug)) { | ||
return vh_get_permission_denied_json_response($permission_slug); | ||
} | ||
|
||
try { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@we-vikram-wri231 writing
has-access-of-advanced-section
text multiple time, no point