-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #16561 #16562
fix #16561 #16562
Conversation
|
For maintainers only:
|
please fix last 2 lint error i worked with ide github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests
ok i need some time |
done, param name changed to |
@TheLarkInn Makse sense to look at this too, don't see somethinb bad here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution 🚀
@TheLarkInn Unmerged due |
I can try add more tests for increasing coverage |
What kind of change does this PR introduce?
see #16561
Did you add tests for your changes?
no
Does this PR introduce a breaking change?
What needs to be documented once your changes are merged?
add
globalObject
option to page with amd library plugin