Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially revert #2026 #2033

Merged
merged 1 commit into from
Apr 13, 2018
Merged

Partially revert #2026 #2033

merged 1 commit into from
Apr 13, 2018

Conversation

montogeek
Copy link
Member

@montogeek montogeek commented Apr 13, 2018 •
edited
Loading

  • Added back page-loader to antwar config,.
  • Remove page-loader it from webpack configuration.
  • Remove Supports component conditional rendering on client.

Tested locally successfully after 10 mins.

We should put our efforts on rebuild branch, I am actively working on it, mean while we have to suffer these long builds.

@montogeek montogeek requested a review from EugeneHlushko April 13, 2018 09:08
@montogeek montogeek mentioned this pull request Apr 13, 2018
Closed
EugeneHlushko
EugeneHlushko approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very weird but it works again 👍

@montogeek montogeek merged commit 247b4ce into master Apr 13, 2018
@montogeek montogeek deleted the fix/home-page-break branch April 13, 2018 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EugeneHlushko EugeneHlushko EugeneHlushko approved these changes

Assignees
No one assigned
Labels
Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@montogeek @EugeneHlushko