-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pwa: Add jest & create snapshot tests for existing components #1397
Comments
Hey @hulkish, @Jorybraun is a first time contributor to FOSS and expressed some desire to tackle (a part of) this. This is a really larger task but I think there's more than enough incremental issues we could break this down into? Personally my jest experience is pretty limited so I'll yield to both of your expertise into determining the right way to separate the work out. Thoughts? Discuss away!! 🤗 |
I think it could be convenient if @Jorybraun and i could share the same fork and pr for this. I'll setup the tooling and create the first few tests as a direction? |
Yes that sounds great! I have spent the last month creating snapshot tests for Vue components at work, but there isn't a senior frontend dev currently to provide feedback. So I think this is a great opportunity for growth :). |
Ok cool. So, just as a heads up I really just have in mind to create very simple snapshot tests. Explained here https://facebook.github.io/jest/docs/snapshot-testing.html |
ok @hulkish sounds great! So you'll be creating the fork, will we create a test directory or should we create folders and keep the tests with their relative components? |
Yep. |
I guess ill wait and see 💯 |
It will be a couple hours, going to see if i can time it so that it comes after #1397 |
Great, I will most likely be starting on it tonight or tomorrow, so no rush 👍 |
moving this to #1400 |
description TBD
The text was updated successfully, but these errors were encountered: