Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pwa: Add jest & create snapshot tests for existing components #1397

Closed
hulkish opened this issue Jul 7, 2017 · 10 comments
Closed

pwa: Add jest & create snapshot tests for existing components #1397

hulkish opened this issue Jul 7, 2017 · 10 comments

Comments

@hulkish
Copy link
Collaborator

hulkish commented Jul 7, 2017

description TBD

@TheLarkInn
Copy link
Member

Hey @hulkish, @Jorybraun is a first time contributor to FOSS and expressed some desire to tackle (a part of) this.

This is a really larger task but I think there's more than enough incremental issues we could break this down into?

Personally my jest experience is pretty limited so I'll yield to both of your expertise into determining the right way to separate the work out.

Thoughts? Discuss away!! 🤗

@hulkish
Copy link
Collaborator Author

hulkish commented Jul 8, 2017

I think it could be convenient if @Jorybraun and i could share the same fork and pr for this. I'll setup the tooling and create the first few tests as a direction?

@Jorybraun
Copy link

Yes that sounds great!

I have spent the last month creating snapshot tests for Vue components at work, but there isn't a senior frontend dev currently to provide feedback. So I think this is a great opportunity for growth :).

@hulkish
Copy link
Collaborator Author

hulkish commented Jul 8, 2017

Ok cool. So, just as a heads up I really just have in mind to create very simple snapshot tests. Explained here https://facebook.github.io/jest/docs/snapshot-testing.html

@Jorybraun
Copy link

ok @hulkish sounds great!

So you'll be creating the fork, will we create a test directory or should we create folders and keep the tests with their relative components?

@hulkish
Copy link
Collaborator Author

hulkish commented Jul 8, 2017

Yep.

@Jorybraun
Copy link

I guess ill wait and see 💯

@hulkish
Copy link
Collaborator Author

hulkish commented Jul 8, 2017

It will be a couple hours, going to see if i can time it so that it comes after #1397

@Jorybraun
Copy link

Great, I will most likely be starting on it tonight or tomorrow, so no rush 👍

@hulkish
Copy link
Collaborator Author

hulkish commented Jul 8, 2017

moving this to #1400

@hulkish hulkish closed this as completed Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants