Skip to content

Commit

Permalink
chore: upgrade webpack/antwar/deps (#980)
Browse files Browse the repository at this point in the history
The main purpose of this PR is just to bring our dependencies,
especially webpack and antwar up to date. In the process of
doing this, we also resolved a variety of bugs and other issues.
There is still much work to be done but this is definitely a step
in the right direction and should make further changes easier.
Here are some other notable changes:

* refactor(components): clean up formatting and usage
* fix(components): fix `PropTypes` warnings
* refactor(config): remove unused vote routes
* refactor(config): utilize `disable` option in the extract plugin to simplify config
* fix(build-process): fix missing `<title>` tags
* fix(components): simplify index page management in sidebar (#1085)
* docs: minor improvements to index pages
* fix(tests): ignore npm-install-weback-plugin

Ignore the "sucks" mention in the npm-install-webpack-plugin file
for now. It isn't used in a derogatory way so I'm not sure we should
change it but I'm also not sure we should `allow` "sucks" globally.
  • Loading branch information
bebraw authored and skipjack committed Sep 2, 2017
1 parent 2b45bbf commit 458141f
Show file tree
Hide file tree
Showing 35 changed files with 2,954 additions and 2,297 deletions.
1 change: 1 addition & 0 deletions .alexignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
generated/plugins/npm-install-webpack-plugin.md
9 changes: 7 additions & 2 deletions .alexrc
Original file line number Diff line number Diff line change
@@ -1,20 +1,24 @@
{
"allow": [
"attacks",
"bigger",
"color",
"colors",
"crash",
"dead",
"dirty",
"disabled",
"dive",
"execute",
"executed",
"executes",
"execution",
"dirty",
"disabled",
"failed",
"failure",
"failures",
"fire",
"hook",
"hooks",
"host-hostess",
"hosts",
"jade",
Expand All @@ -23,6 +27,7 @@
"period",
"pros",
"reject",
"remain",
"remains",
"white"
]
Expand Down
14 changes: 6 additions & 8 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
# Top-most EditorConfig file
root = true

# Set default charset
[*.{js}]
charset = utf-8

# AutoFormat All Files
[*]
trim_trailing_whitespace = true
insert_final_newline = true

# 4 space indentation
[*.{md,js,jsx,scss,hbs}]
# Format All Source Files
[*.{md,js,jsx,json,scss,hbs,*rc}]
charset = utf-8
indent_style = space
indent_size = 2

# Format Config
[{package.json,.alexrc,babelrc,.eslintignore,.eslintrc,.markdownlint.json,.proselintrc}]
# Format Any Missing Config Files
[.eslintignore]
indent_style = space
indent_size = 2
5 changes: 5 additions & 0 deletions .postcssrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module.exports = {
plugins: [
require('autoprefixer')
]
}
4 changes: 2 additions & 2 deletions bootstrap.js → antwar.bootstrap.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const antwar = require('antwar');

const environment = process.env.npm_lifecycle_event || 'build';
const environment = process.argv[2];

// Patch Babel env to make HMR switch work
process.env.BABEL_ENV = environment;
Expand All @@ -9,7 +9,7 @@ antwar[environment]({
environment,
antwar: require('./antwar.config'),
webpack: require('./webpack.config')
}).catch(function (err) {
}).catch((err) => {
console.error(err);

process.exit(1);
Expand Down
Loading

0 comments on commit 458141f

Please sign in to comment.