-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(contributing): commands to install jest globally #777
Conversation
Add commands to install jest globally for running individual tests ISSUES CLOSED: webpack#775
No need to install when |
Add yarn before jest to grab the local binary of jest from node_modules to run individual tests ISSUES CLOSED: webpack#775
Add docs to either install jest or use the locally installed binaries from node_modules ISSUES CLOSED: webpack#775
@playma256 updated, looks better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @anshumanv ,
Left a suggestion for you.
Updated instructions to run individual tests in contributing.md ISSUES CLOSED: webpack#775
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, nearly there!
Added : at the end of paragraphs ISSUES CLOSED: webpack#775
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evenstensberg Please review the new changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Add commands to install jest globally for running individual tests
ISSUES CLOSED: #775
What kind of change does this PR introduce?
Docs
Did you add tests for your changes?
NA
If relevant, did you update the documentation?
Yes
Summary
Added commands to install jest cli for running tests.
Does this PR introduce a breaking change?
No
Other information
NA