Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contributing): commands to install jest globally #777

Merged
merged 5 commits into from
Mar 8, 2019

Conversation

anshumanv
Copy link
Member

Add commands to install jest globally for running individual tests

ISSUES CLOSED: #775

What kind of change does this PR introduce?
Docs

Did you add tests for your changes?
NA

If relevant, did you update the documentation?
Yes

Summary
Added commands to install jest cli for running tests.

Does this PR introduce a breaking change?
No

Other information
NA

Add commands to install jest globally for running individual tests

ISSUES CLOSED: webpack#775
@jsf-clabot
Copy link

jsf-clabot commented Mar 6, 2019

CLA assistant check
All committers have signed the CLA.

@matheus1lva
Copy link
Member

No need to install when npx is already available for us.
On yarn, running yarn jest grabs the binary from local node_modules

Add yarn before jest to grab the local binary of jest from node_modules to run individual tests

ISSUES CLOSED: webpack#775
Add docs to either install jest or use the locally installed binaries from node_modules

ISSUES CLOSED: webpack#775
@anshumanv
Copy link
Member Author

@playma256 updated, looks better?

Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @anshumanv ,
Left a suggestion for you.

Updated instructions to run individual tests in contributing.md

ISSUES CLOSED: webpack#775
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nearly there!

Added : at the end of paragraphs

ISSUES CLOSED: webpack#775
@webpack-bot
Copy link

@anshumanv Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evenstensberg Please review the new changes.

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@evenstensberg evenstensberg merged commit 17103d7 into webpack:master Mar 8, 2019
@anshumanv anshumanv deleted the 775 branch March 9, 2019 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs(contributing): Specify global installation of jest while running single tests
7 participants