-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(init): fix init prompt installation #742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can see how we did this at the next
branch
Hi @evenstensberg, |
You can navigate the lib folder, it's not that big, and you learn the new internals |
@evenstensberg we don't do a global installation of
Which one I should implement? |
Do as 1. Does it and ill review |
@rishabh3112 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evenstensberg Please review the new changes. |
Did that @evenstensberg |
Any review here 😅? |
Done @evenstensberg |
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
1 similar comment
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
Add setup walk through and add usage description
@evenstensberg after rebase with master NodeJS stable is failing on this PR. |
@evenstensberg After investigation error is certainly due to pasting error for the reference.
|
Any fix to this? |
@evenstensberg This is fixed at jest. |
Updating jest to v24.3.0 would fix this. |
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
N/A
Summary
#741
Does this PR introduce a breaking change?
No
Other information