refactor: drop webpack v4 from tests, packages, and CI

.cspell.json

@@ -94,7 +94,10 @@
     "Nitin",
     "smoketest",
     "dbaeumer",
-    "esbenp"
+    "esbenp",
+    "msuccessfully",
+    "mfirst",
+    "msecond"
   ],
   "dictionaries": ["npm", "software-terms"],
   "ignorePaths": [

.github/workflows/nodejs.yml

@@ -63,10 +63,6 @@ jobs:
             os: ubuntu-latest
             dev-server-version: version-3
             webpack-version: latest
-          - node-version: 16.x
-            os: ubuntu-latest
-            dev-server-version: latest
-            webpack-version: webpack-4
 
     steps:
       - uses: actions/checkout@v3
@@ -82,10 +78,6 @@ jobs:
       - name: Install dependencies
         run: yarn --frozen-lockfile --ignore-engines
 
-      - name: Install webpack ${{ matrix.webpack-version }}
-        if: matrix.webpack-version == '4'
-        run: yarn add -W webpack@${{ matrix.webpack-version }} --ignore-engines
-
       - name: Install webpack-dev-server ${{ matrix.dev-server-version }}
         if: matrix.dev-server-version == 'version-3'
         run: yarn add -W webpack-dev-server@${{ matrix.dev-server-version }} --ignore-engines

packages/configtest/package.json

@@ -17,7 +17,7 @@
     "lib"
   ],
   "peerDependencies": {
-    "webpack": "4.x.x || 5.x.x",
+    "webpack": "5.x.x",
     "webpack-cli": "4.x.x"
   }
 }

packages/generators/package.json

@@ -27,7 +27,8 @@
     "yeoman-generator": "^4.12.0"
   },
   "peerDependencies": {
-    "webpack": "4.x.x || 5.x.x"
+    "webpack": "5.x.x",
+    "webpack-cli": "4.x.x"
   },
   "peerDependenciesMeta": {
     "prettier": {

packages/info/package.json

@@ -21,6 +21,7 @@
   },
   "gitHead": "fb50f766851f500ca12867a2aa9de81fa6e368f9",
   "peerDependencies": {
+    "webpack": "5.x.x",
     "webpack-cli": "4.x.x"
   },
   "devDependencies": {

packages/serve/package.json

@@ -18,6 +18,7 @@
     "lib"
   ],
   "peerDependencies": {
+    "webpack": "5.x.x",
     "webpack-cli": "4.x.x"
   },
   "peerDependenciesMeta": {

packages/serve/src/index.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line node/no-extraneous-import
 import type { Compiler, cli } from "webpack";
 import { IWebpackCLI, WebpackDevServerOptions } from "webpack-cli";
 

packages/webpack-cli/package.json

@@ -48,7 +48,7 @@
     "webpack-merge": "^5.7.3"
   },
   "peerDependencies": {
-    "webpack": "4.x.x || 5.x.x"
+    "webpack": "5.x.x"
   },
   "peerDependenciesMeta": {
     "@webpack-cli/generators": {

test/build/cache/cache.test.js

@@ -3,7 +3,7 @@
 const path = require("path");
 // eslint-disable-next-line node/no-unpublished-require
 const rimraf = require("rimraf");
-const { run, isWebpack5 } = require("../../utils/test-utils");
+const { run } = require("../../utils/test-utils");
 
 describe("cache", () => {
   it("should work", async () => {
@@ -14,25 +14,19 @@ describe("cache", () => {
     let { exitCode, stderr, stdout } = await run(__dirname, ["-c", "./webpack.config.js"]);
 
     expect(exitCode).toEqual(0);
-
-    if (isWebpack5) {
-      expect(stderr.match(/No pack exists at/g)).toHaveLength(1);
-      expect(stderr.match(/Stored pack/g)).toHaveLength(1);
-      expect(stderr).toBeTruthy();
-      expect(stdout).toBeTruthy();
-    }
+    expect(stderr.match(/No pack exists at/g)).toHaveLength(1);
+    expect(stderr.match(/Stored pack/g)).toHaveLength(1);
+    expect(stderr).toBeTruthy();
+    expect(stdout).toBeTruthy();
 
     ({ exitCode, stderr, stdout } = await run(__dirname, ["-c", "./webpack.config.js"]));
 
     expect(exitCode).toEqual(0);
-
-    if (isWebpack5) {
-      expect(stderr.match(/restore cache container:/g)).toHaveLength(1);
-      expect(stderr.match(/restore cache content metadata:/g)).toHaveLength(1);
-      expect(stderr.match(/restore cache content \d+ \(.+\):/g)).toHaveLength(1);
-      expect(stderr).toBeTruthy();
-      expect(stdout).toBeTruthy();
-    }
+    expect(stderr.match(/restore cache container:/g)).toHaveLength(1);
+    expect(stderr.match(/restore cache content metadata:/g)).toHaveLength(1);
+    expect(stderr.match(/restore cache content \d+ \(.+\):/g)).toHaveLength(1);
+    expect(stderr).toBeTruthy();
+    expect(stdout).toBeTruthy();
   });
 
   it("should work in multi compiler mode", async () => {
@@ -46,25 +40,19 @@ describe("cache", () => {
     let { exitCode, stderr, stdout } = await run(__dirname, ["-c", "./multi.config.js"]);
 
     expect(exitCode).toEqual(0);
-
-    if (isWebpack5) {
-      expect(stderr.match(/No pack exists at/g)).toHaveLength(2);
-      expect(stderr.match(/Stored pack/g)).toHaveLength(2);
-      expect(stderr).toBeTruthy();
-      expect(stdout).toBeTruthy();
-    }
+    expect(stderr.match(/No pack exists at/g)).toHaveLength(2);
+    expect(stderr.match(/Stored pack/g)).toHaveLength(2);
+    expect(stderr).toBeTruthy();
+    expect(stdout).toBeTruthy();
 
     ({ exitCode, stderr, stdout } = await run(__dirname, ["-c", "./multi.config.js"]));
 
     expect(exitCode).toEqual(0);
-
-    if (isWebpack5) {
-      expect(stderr.match(/restore cache container:/g)).toHaveLength(2);
-      expect(stderr.match(/restore cache content metadata:/g)).toHaveLength(2);
-      expect(stderr.match(/restore cache content \d+ \(.+\):/g)).toHaveLength(2);
-      expect(stderr).toBeTruthy();
-      expect(stdout).toBeTruthy();
-    }
+    expect(stderr.match(/restore cache container:/g)).toHaveLength(2);
+    expect(stderr.match(/restore cache content metadata:/g)).toHaveLength(2);
+    expect(stderr.match(/restore cache content \d+ \(.+\):/g)).toHaveLength(2);
+    expect(stderr).toBeTruthy();
+    expect(stdout).toBeTruthy();
   });
 
   it("should work in multi compiler mode with the `--config-name` argument", async () => {
@@ -82,13 +70,10 @@ describe("cache", () => {
     ]);
 
     expect(exitCode).toEqual(0);
-
-    if (isWebpack5) {
-      expect(stderr.match(/No pack exists at/g)).toHaveLength(1);
-      expect(stderr.match(/Stored pack/g)).toHaveLength(1);
-      expect(stderr).toBeTruthy();
-      expect(stdout).toBeTruthy();
-    }
+    expect(stderr.match(/No pack exists at/g)).toHaveLength(1);
+    expect(stderr.match(/Stored pack/g)).toHaveLength(1);
+    expect(stderr).toBeTruthy();
+    expect(stdout).toBeTruthy();
 
     ({ exitCode, stderr, stdout } = await run(__dirname, [
       "-c",
@@ -100,14 +85,11 @@ describe("cache", () => {
     ]));
 
     expect(exitCode).toEqual(0);
-
-    if (isWebpack5) {
-      expect(stderr.match(/restore cache container:/g)).toHaveLength(1);
-      expect(stderr.match(/restore cache content metadata:/g)).toHaveLength(1);
-      expect(stderr.match(/restore cache content \d+ \(.+\):/g)).toHaveLength(1);
-      expect(stderr).toBeTruthy();
-      expect(stdout).toBeTruthy();
-    }
+    expect(stderr.match(/restore cache container:/g)).toHaveLength(1);
+    expect(stderr.match(/restore cache content metadata:/g)).toHaveLength(1);
+    expect(stderr.match(/restore cache content \d+ \(.+\):/g)).toHaveLength(1);
+    expect(stderr).toBeTruthy();
+    expect(stdout).toBeTruthy();
   });
 
   it("should work with the `--merge` argument", async () => {
@@ -126,13 +108,10 @@ describe("cache", () => {
     ]);
 
     expect(exitCode).toEqual(0);
-
-    if (isWebpack5) {
-      expect(stderr.match(/No pack exists at/g)).toHaveLength(1);
-      expect(stderr.match(/Stored pack/g)).toHaveLength(1);
-      expect(stderr).toBeTruthy();
-      expect(stdout).toBeTruthy();
-    }
+    expect(stderr.match(/No pack exists at/g)).toHaveLength(1);
+    expect(stderr.match(/Stored pack/g)).toHaveLength(1);
+    expect(stderr).toBeTruthy();
+    expect(stdout).toBeTruthy();
 
     ({ exitCode, stderr, stdout } = await run(__dirname, [
       "-c",
@@ -145,14 +124,11 @@ describe("cache", () => {
     ]));
 
     expect(exitCode).toEqual(0);
-
-    if (isWebpack5) {
-      expect(stderr.match(/restore cache container:/g)).toHaveLength(1);
-      expect(stderr.match(/restore cache content metadata:/g)).toHaveLength(1);
-      expect(stderr.match(/restore cache content \d+ \(.+\):/g)).toHaveLength(1);
-      expect(stderr).toBeTruthy();
-      expect(stdout).toBeTruthy();
-    }
+    expect(stderr.match(/restore cache container:/g)).toHaveLength(1);
+    expect(stderr.match(/restore cache content metadata:/g)).toHaveLength(1);
+    expect(stderr.match(/restore cache content \d+ \(.+\):/g)).toHaveLength(1);
+    expect(stderr).toBeTruthy();
+    expect(stdout).toBeTruthy();
   });
 
   it("should work with the `--config-name` and `--merge` argument", async () => {
@@ -175,13 +151,10 @@ describe("cache", () => {
     ]);
 
     expect(exitCode).toEqual(0);
-
-    if (isWebpack5) {
-      expect(stderr.match(/No pack exists at/g)).toHaveLength(1);
-      expect(stderr.match(/Stored pack/g)).toHaveLength(1);
-      expect(stderr).toBeTruthy();
-      expect(stdout).toBeTruthy();
-    }
+    expect(stderr.match(/No pack exists at/g)).toHaveLength(1);
+    expect(stderr.match(/Stored pack/g)).toHaveLength(1);
+    expect(stderr).toBeTruthy();
+    expect(stdout).toBeTruthy();
 
     ({ exitCode, stderr, stdout } = await run(__dirname, [
       "-c",
@@ -198,14 +171,11 @@ describe("cache", () => {
     ]));
 
     expect(exitCode).toEqual(0);
-
-    if (isWebpack5) {
-      expect(stderr.match(/restore cache container:/g)).toHaveLength(1);
-      expect(stderr.match(/restore cache content metadata:/g)).toHaveLength(1);
-      expect(stderr.match(/restore cache content \d+ \(.+\):/g)).toHaveLength(1);
-      expect(stderr).toBeTruthy();
-      expect(stdout).toBeTruthy();
-    }
+    expect(stderr.match(/restore cache container:/g)).toHaveLength(1);
+    expect(stderr.match(/restore cache content metadata:/g)).toHaveLength(1);
+    expect(stderr.match(/restore cache content \d+ \(.+\):/g)).toHaveLength(1);
+    expect(stderr).toBeTruthy();
+    expect(stdout).toBeTruthy();
   });
 
   it("should work with autoloading configuration", async () => {
@@ -219,24 +189,18 @@ describe("cache", () => {
     let { exitCode, stderr, stdout } = await run(__dirname, ["--name", "cache-test-autoloading"]);
 
     expect(exitCode).toEqual(0);
-
-    if (isWebpack5) {
-      expect(stderr.match(/No pack exists at/g)).toHaveLength(1);
-      expect(stderr.match(/Stored pack/g)).toHaveLength(1);
-      expect(stderr).toBeTruthy();
-      expect(stdout).toBeTruthy();
-    }
+    expect(stderr.match(/No pack exists at/g)).toHaveLength(1);
+    expect(stderr.match(/Stored pack/g)).toHaveLength(1);
+    expect(stderr).toBeTruthy();
+    expect(stdout).toBeTruthy();
 
     ({ exitCode, stderr, stdout } = await run(__dirname, ["--name", "cache-test-autoloading"]));
 
     expect(exitCode).toEqual(0);
-
-    if (isWebpack5) {
-      expect(stderr.match(/restore cache container:/g)).toHaveLength(1);
-      expect(stderr.match(/restore cache content metadata:/g)).toHaveLength(1);
-      expect(stderr.match(/restore cache content \d+ \(.+\):/g)).toHaveLength(1);
-      expect(stderr).toBeTruthy();
-      expect(stdout).toBeTruthy();
-    }
+    expect(stderr.match(/restore cache container:/g)).toHaveLength(1);
+    expect(stderr.match(/restore cache content metadata:/g)).toHaveLength(1);
+    expect(stderr.match(/restore cache content \d+ \(.+\):/g)).toHaveLength(1);
+    expect(stderr).toBeTruthy();
+    expect(stdout).toBeTruthy();
   });
 });