bugfix - sets the default entry point if not provided #268
Conversation
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
| @@ -95,6 +95,14 @@ exports[`entry transforms correctly using "entry-0" data 12`] = ` | |||
| " | |||
| `; | |||
|
|
|||
| exports[`entry transforms correctly using "entry-0" data 13`] = ` | |||
| "module.exports = { | |||
| entry: module.exports = {} | |||
There was a problem hiding this comment.
Yup ideally an empty object should work no?
There was a problem hiding this comment.
Correction: an empty config object
There was a problem hiding this comment.
I think I'm testing the wrong thing - this is the yeoman transformation test snapshot.
55a6067 to
a4cc5fa
Compare
|
Codacy looks to be a flake when I look at it, Ship it.gif |
There was a problem hiding this comment.
Instead of setting a default here, which webpack/webpack@WebpackOptionsDefaulter.js
Let's instead just remove the check that validates the existence of options.entry entirely. So tl;dr webpack-cli doesn't warn, or prevent webpack-dev-server from running webpack without an entry provided.
Am I missing something there?
|
Turns out the issue lies with the Closing this PR. |
What kind of change does this PR introduce?
Sets the default entry point to
./srcif it isn't provided in the webpack config (or if no config is provided at all).Did you add tests for your changes?
No, there's no test coverage of
convert-argv.jsIf relevant, did you update the documentation?
No, as this is covered by the normal webpack documentation.
Summary
When trying to run
webpack-dev-serverwith no config file or no entry set, it did not default to./srclike the webpack compiler does.It solves this issue - webpack/webpack-dev-server#1308
Does this PR introduce a breaking change?
No