Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(utils): remove cross-spawn #2097

Merged
merged 1 commit into from
Nov 10, 2020
Merged

chore(utils): remove cross-spawn #2097

merged 1 commit into from
Nov 10, 2020

Conversation

jamesgeorge007
Copy link
Member

What kind of change does this PR introduce?
chore

Did you add tests for your changes?
Updated existing tests.

If relevant, did you update the documentation?
Nope

Summary
Remove extraneous dependency cross-spawn.

Does this PR introduce a breaking change?
Nope

Other information
N/A

chore: update yarn.lock
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #2097 (fb84255) into master (f9875e9) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2097   +/-   ##
=======================================
  Coverage   68.63%   68.63%           
=======================================
  Files          76       76           
  Lines        2401     2401           
  Branches      496      496           
=======================================
  Hits         1648     1648           
  Misses        753      753           
Impacted Files Coverage Δ
packages/utils/src/global-packages-path.ts 72.72% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9875e9...fb84255. Read the comment docs.

@anshumanv
Copy link
Member

there are 3 jobs running, please cancel CI jobs when pushing multiple times to save CI time

@anshumanv anshumanv merged commit b4289c0 into master Nov 10, 2020
@anshumanv anshumanv deleted the remove-extraneous-dep branch November 10, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants