-
-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configure codecov reporting #2032
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2032 +/- ##
==========================================
+ Coverage 59.44% 68.99% +9.55%
==========================================
Files 102 85 -17
Lines 2611 2422 -189
Branches 518 489 -29
==========================================
+ Hits 1552 1671 +119
+ Misses 931 751 -180
+ Partials 128 0 -128 Continue to review full report at Codecov.
|
CI seems super slow 😞 |
Yup, but unrelated to this PR as individual jobs are taking same amount of time as they where before. Issue is that the less number of jobs are not running simultaneously per PR because of sudden increase of commits in repository as a whole. |
hmm, I think we should cancel the previous run manually if we push a new commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
@rishabh3112 Can we focus on @webpack/cli-team Also we should improve coverage - just more tests, ideally have 95-100% coverage |
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
No
Summary
Configure reporting of codecov
Does this PR introduce a breaking change?
No
Other information
related to #1899