-
-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: coverage #1899
Merged
Merged
feat: coverage #1899
Changes from 13 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
ba5e281
chore: basic configuration of action
rishabh3112 208e254
chore: add steps
rishabh3112 8bf435a
chore: add coverage command
rishabh3112 0e250c5
chore: add install and build
rishabh3112 95f5087
chore: update name
rishabh3112 b9bb096
chore: lint and enable comment
rishabh3112 fe41af0
chore: add nyc
rishabh3112 1d9cc7e
chore: debug skip typescript test
rishabh3112 0be664d
chore: comment build till coverage setup
rishabh3112 ec31b5c
chore: shift to nyc for coverage
rishabh3112 c623872
chore: full comment
rishabh3112 8c03c12
chore: enable coverage everywhere
rishabh3112 1f49701
chore: configure with source maps
rishabh3112 d04660c
chore: run on all tests
rishabh3112 ea02f43
chore: enable sourcemap on ci only
rishabh3112 cf25fe4
chore: rebase
rishabh3112 79bb097
chore: update build:ci
rishabh3112 24b4d9d
Merge branch 'master' into feat/coverage
rishabh3112 5e0a1a1
chore: update lock file
rishabh3112 7614d54
chore: enable typescript test
rishabh3112 9949b46
chore: add tsconfig for ts test
rishabh3112 a60c301
chore: update progress profile
rishabh3112 c3cdf92
chore: skip ts test
rishabh3112 b983d68
chore: update progress test
rishabh3112 1df5aac
chore: lint
rishabh3112 0a7dee1
chore: lint file
rishabh3112 d657faf
Merge branch 'master' into feat/coverage
rishabh3112 a372ac8
chore: use forceExit
rishabh3112 fa7789c
Merge branch 'feat/coverage' of https://github.com/webpack/webpack-cl…
rishabh3112 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
comment: off | ||
comment: on | ||
|
||
parsers: | ||
javascript: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"all": true, | ||
"reporter": [ | ||
"html", | ||
"json", | ||
"cobertura" | ||
], | ||
"source-map": true, | ||
"exclude-after-remap": false | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why skip?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not working with
nyc
🤷🏻♂️ , need a fix.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why we need nyc when jest has it inbuilt?
/cc @evilebottnawi
Maybe we should remove it and use
jest --coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jestjs/jest#3190
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh spawned process mess, we need to get to this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep spawned process