Skip to content
This repository has been archived by the owner on Sep 9, 2021. It is now read-only.

refactor: rename the name option #261

Merged
merged 2 commits into from
Jul 28, 2020

Conversation

alexander-akait
Copy link
Member

BREAKING CHANGE: the name option was renamed to the filename option

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

partial #199

Breaking Changes

Yes

Additional Info

Docs will be updated lately

BREAKING CHANGE: the `name` option was renamed to the `filename` option
@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #261 into master will decrease coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
- Coverage   77.11%   76.92%   -0.20%     
==========================================
  Files           6        6              
  Lines         118      117       -1     
  Branches       36       35       -1     
==========================================
- Hits           91       90       -1     
  Misses         25       25              
  Partials        2        2              
Impacted Files Coverage Δ
src/index.js 93.93% <100.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0d9887...41779a4. Read the comment docs.

@alexander-akait alexander-akait merged commit 8d7cae0 into master Jul 28, 2020
@alexander-akait alexander-akait deleted the refactor-rename-the-name-option branch July 28, 2020 11:20
TheLD6978 pushed a commit to TheLD6978/worker-loader that referenced this pull request Apr 16, 2021
BREAKING CHANGE: the `name` option was renamed to the `filename` option
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant