-
-
Notifications
You must be signed in to change notification settings - Fork 179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR, can you add tests and comment in code about problem (minimum)?
How would you approach testing this? |
@the-ress you need mock |
e988525
to
81e77b6
Compare
Codecov Report
@@ Coverage Diff @@
## master #372 +/- ##
==========================================
+ Coverage 97.69% 97.71% +0.02%
==========================================
Files 5 5
Lines 260 263 +3
Branches 102 102
==========================================
+ Hits 254 257 +3
Misses 6 6
Continue to review full report at Codecov.
|
81e77b6
to
84316f4
Compare
@evilebottnawi I added the tests and comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good, need move test in https://github.com/webpack-contrib/uglifyjs-webpack-plugin/blob/master/test/parallel-option.test.js
(group tests together) and update snapshot
for windows
(use -u
flag)
@evilebottnawi Does the Windows build pass on master? |
@the-ress yes, sometimes |
/cc @the-ress |
Close in favor #380, thanks for PR and sorry for delay (many works) |
This PR contains a:
Motivation / Use-Case
When the worker process fails to spawn, (and only when using cache), the error turns into an unhandled promise rejection and
uglifyjs-webpack-plugin
hangs and never finishes.This PR fixes that by catching the error and handling it the same way as in the non-concurrent path.
Breaking Changes
I don't think there are any.
Additional Info