Skip to content
This repository was archived by the owner on Dec 5, 2019. It is now read-only.

fix: pin uglify-js to an older version #356

Closed
wants to merge 1 commit into from

Conversation

lukeapage
Copy link
Contributor

This allows users of the plugin to pin to older versions to avoid bugs.
3.1.4 picked purely because its in the package lock file as what handlebars pins to.
Fixes #355

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

See bug #355

This allows users of the plugin to pin to older versions to avoid bugs.
3.1.4 picked purely because its in the package lock file as what handlebars pins to.
Fixes webpack-contrib#355
@lukeapage lukeapage changed the title fix: ping uglify-js to an older version fix: pin uglify-js to an older version Sep 17, 2018
@@ -47,7 +47,7 @@
"schema-utils": "^1.0.0",
"serialize-javascript": "^1.4.0",
"source-map": "^0.6.1",
"uglify-js": "^3.4.9",
"uglify-js": "^3.1.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just ^3.0.0?

@alexander-akait
Copy link
Member

Done here #357

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UfligyJS un-necessarily pinned at the latest and buggy release
2 participants