support loaderContext.getLogger #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support multiple logger arguments
The babel-loade issue is already caught by the sass-loader integration tests
|
|
JLHwung
commented
Sep 16, 2024
alexander-akait
approved these changes
Sep 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #216 +/- ##
==========================================
- Coverage 21.23% 19.00% -2.23%
==========================================
Files 8 8
Lines 504 563 +59
Branches 108 111 +3
==========================================
Hits 107 107
- Misses 348 405 +57
- Partials 49 51 +2 ☔ View full report in Codecov by Sentry. |
158d52b
into
webpack-contrib:master
14 of 17 checks passed
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
See original PR #130 for the motivation.
Breaking Changes
Additional Info
Closes #130
Fixes #185
Closes #198
Fixes babel/babel-loader#1043
This PR is based on #130. In this PR we fixed the bug that caused the worker hanging, aligned the less-loader test case with the sass-loader one and incorporated the review comment #185 (comment).
We also bumped babel-loader to 9.2.0, which is also affected by the issue #185.