-
-
Notifications
You must be signed in to change notification settings - Fork 121
Add eslint 6 support #275
Add eslint 6 support #275
Conversation
Check failes on Node.js 6 |
This patch looks good. ESLint 6 no longer supports Node.js 6, so the CI build failing for Node 6 is expected. Probably need to update |
Hi everyone, I'm from ESLint. Instead of doing a direct require to a formatter path, I would recommend Requiring the path directly is not part of the public API and could change any time, even in patch releases. The two Good luck! Please stop by our Gitter chat if you need help. |
@HDuck See #238 (comment) regarding the recommended approach for the formatter options. |
I'll fix it all today. Thanks for assisting. If anyone knows how to change travis config to install eslint 5 on node 6 I'll appreciate additional help. ;) |
@HDuck I have a suggestion which drop node 6 in travis.yml file and add node engines require in package.json { "engines" : { "node" : "> 6" } } ,then update the doc. Because for Eslint 6 , Node.js 6 is no longer supported it . |
Fixes #271 This PR would fix the |
Ping me when the PR was ready for review |
@evilebottnawi ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two changes. One note. Also do you test this code with eslint@5
? We doesn't have CI tests on this case, so need manual testing. Thanks for PR.
@evilebottnawi Tested manually |
Should the README be updated to reflect the new usage? |
Fixed tests to check eslint ver.6. Added eslint-6 support.