Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support running under alpine and musl-based environments: use GLOB_BRACE only when defined #29

Merged
merged 8 commits into from
Jan 21, 2021
Merged

Support running under alpine and musl-based environments: use GLOB_BRACE only when defined #29

merged 8 commits into from
Jan 21, 2021

Conversation

Firehed
Copy link
Contributor

@Firehed Firehed commented Jan 20, 2021

Fixes #15

@Firehed
Copy link
Contributor Author

Firehed commented Jan 20, 2021

I saw an equivalent linked PR that stated tests need to run on Alpine too. I'll look into it.

Ocramius
Ocramius approved these changes Jan 21, 2021
View reviewed changes
Copy link
Collaborator

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius changed the title Only use GLOB_BRACE when defined Support running under alpine and musl-based environments: use GLOB_BRACE only when defined Jan 21, 2021
@Ocramius Ocramius self-assigned this Jan 21, 2021
@Ocramius Ocramius added this to the 4.3.0 milestone Jan 21, 2021
@Ocramius Ocramius merged commit 06358fa into webmozarts:4.3.x Jan 21, 2021
@Ocramius
Copy link
Collaborator

Excellent work, @Firehed! Thanks!

@Ocramius Ocramius added the bug label Jan 21, 2021
@stof
Copy link

stof commented Jan 21, 2021

what happens for globs which are using braces ?

@Ocramius
Copy link
Collaborator

@stof you'll have to be more specific about that, I fear. Perhaps issue outlining the potential problem?

@stof
Copy link

stof commented Jan 21, 2021

The support for alpine is "added" here by skipping the GLOB_BRACE constant. But this means that any glob pattern which actually uses braces (and so justify passing GLOB_BRACE to enable support for them) won't work on alpine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
bug dependencies enhancement
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

GLOB_BRACE not defined in Alpine
3 participants
@Firehed @Ocramius @stof