-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert MLOperand methods into readonly attributes #774
Convert MLOperand methods into readonly attributes #774
Conversation
Hmm unfortunately this style of migration may not be possible in this case, since the Blink bindings code doesn't support interfaces which have a method and an attribute of the same name. See the crashes in https://crrev.com/c/5975719 We can have getters or methods, but not both at the same time... so a migration period is not possible :/ Would you prefer to make this change now or later? |
Well I'd like to frontload any breaking changes sooner than later, which smoothens the path to origin trial. However, if we can't mitigate this in any way on the Chromium end, can we closely synchronize the changes by having the corresponding update in samples already ready before completing the Chromium change? @ibelem : For the ORT-based samples, maybe we could update the sample logic to map a given Chromium version to a correspondingly compatible build of ORT, so there is implicitly a window of migration in the sample logic? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adapt to spec change at webmachinelearning/webnn#774
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
SHA: 673c6b5 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Adapt to spec change at webmachinelearning/webnn#774
Adapt to spec change at webmachinelearning/webnn#774
SHA: 673c6b5 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…#22653) Adapt to spec change at webmachinelearning/webnn#774
…#22653) Adapt to spec change at webmachinelearning/webnn#774
…#22653) Adapt to spec change at webmachinelearning/webnn#774
Fixes #666
Implements the changes proposed in #666 (comment) while simplifying the declaration of these getters to use the pattern suggested in https://webidl.spec.whatwg.org/#idl-frozen-array
Preview | Diff