bump to node20 #201
Merged
bump to node20 #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to get this merged as well! @mpdude |
Closed
marcispauls
approved these changes
Jan 26, 2024
|
👍 Would be nice to have this merged |
|
Yes waiting to be merge.. Workflow started showing node16 deprecation warnings. |
|
Same here |
|
Hi, @sebastiankugler and @mpdude 👋 |
Aasif001
approved these changes
Feb 2, 2024
setoelkahfi
approved these changes
Feb 2, 2024
|
We are waiting for this. |
|
We'll look into this soon. Thanks for your patience! |
gosuto-inzasheru
approved these changes
Feb 2, 2024
Closed
|
@archen I think this should also change the use from checkout@v3 -> checkout@v4 in the demo example and README. Otherwise people following these will have the same warnings |
|
@nasmorn you want the non-functional change in this PR? I was trying to keep the PR isolated to the relevant bits that un-break the usage rather than a comprehensive update. |
|
It is for the maintainers to decide anyways @archen. I just thought I mention it here, but I guess you are right, you are not the correct addressee |
|
Thank you @archen for the PR and everyone else for your patience. |
github-merge-queue bot
referenced
this pull request
in TheHackerApp/setup-rust
May 3, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [webfactory/ssh-agent](https://togithub.com/webfactory/ssh-agent) | action | minor | `v0.8.0` -> `v0.9.0` | --- ### Release Notes <details> <summary>webfactory/ssh-agent (webfactory/ssh-agent)</summary> ### [`v0.9.0`](https://togithub.com/webfactory/ssh-agent/releases/tag/v0.9.0): Update to `node20` [Compare Source](https://togithub.com/webfactory/ssh-agent/compare/v0.8.0...v0.9.0) This release updates the action to run on Node.js v20. When you're running on GitHub hosted runners, just go ahead and update. When you're using self-hosted runners, please make sure you have Node.js v20 installed before updating from `v0.8.0` to `v0.9.0` of this action. #### New Contributors - [@​npwolf](https://togithub.com/npwolf) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/196](https://togithub.com/webfactory/ssh-agent/pull/196) - [@​benzado](https://togithub.com/benzado) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/206](https://togithub.com/webfactory/ssh-agent/pull/206) - [@​felix-seifert](https://togithub.com/felix-seifert) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/199](https://togithub.com/webfactory/ssh-agent/pull/199) - [@​archen](https://togithub.com/archen) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/201](https://togithub.com/webfactory/ssh-agent/pull/201) **Full Changelog**: webfactory/ssh-agent@v0.8.0...v0.9.0 #### What's Changed - Update README.md to reflect latest version by [@​npwolf](https://togithub.com/npwolf) in [https://github.com/webfactory/ssh-agent/pull/196](https://togithub.com/webfactory/ssh-agent/pull/196) - Remove outdated claim from README by [@​benzado](https://togithub.com/benzado) in [https://github.com/webfactory/ssh-agent/pull/206](https://togithub.com/webfactory/ssh-agent/pull/206) - chore: update all versions of `actions/checkout` to v4 by [@​felix-seifert](https://togithub.com/felix-seifert) in [https://github.com/webfactory/ssh-agent/pull/199](https://togithub.com/webfactory/ssh-agent/pull/199) - bump to node20 by [@​archen](https://togithub.com/archen) in [https://github.com/webfactory/ssh-agent/pull/201](https://togithub.com/webfactory/ssh-agent/pull/201) #### New Contributors - [@​npwolf](https://togithub.com/npwolf) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/196](https://togithub.com/webfactory/ssh-agent/pull/196) - [@​benzado](https://togithub.com/benzado) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/206](https://togithub.com/webfactory/ssh-agent/pull/206) - [@​felix-seifert](https://togithub.com/felix-seifert) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/199](https://togithub.com/webfactory/ssh-agent/pull/199) - [@​archen](https://togithub.com/archen) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/201](https://togithub.com/webfactory/ssh-agent/pull/201) **Full Changelog**: webfactory/ssh-agent@v0.8.0...v0.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/TheHackerApp/setup-rust). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
May 29, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [webfactory/ssh-agent](https://togithub.com/webfactory/ssh-agent) | action | minor | `v0.8.0` -> `v0.9.0` | --- ### Release Notes <details> <summary>webfactory/ssh-agent (webfactory/ssh-agent)</summary> ### [`v0.9.0`](https://togithub.com/webfactory/ssh-agent/releases/tag/v0.9.0): Update to `node20` [Compare Source](https://togithub.com/webfactory/ssh-agent/compare/v0.8.0...v0.9.0) This release updates the action to run on Node.js v20. When you're running on GitHub hosted runners, just go ahead and update. When you're using self-hosted runners, please make sure you have Node.js v20 installed before updating from `v0.8.0` to `v0.9.0` of this action. #### New Contributors - [@​npwolf](https://togithub.com/npwolf) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/196](https://togithub.com/webfactory/ssh-agent/pull/196) - [@​benzado](https://togithub.com/benzado) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/206](https://togithub.com/webfactory/ssh-agent/pull/206) - [@​felix-seifert](https://togithub.com/felix-seifert) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/199](https://togithub.com/webfactory/ssh-agent/pull/199) - [@​archen](https://togithub.com/archen) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/201](https://togithub.com/webfactory/ssh-agent/pull/201) **Full Changelog**: webfactory/ssh-agent@v0.8.0...v0.9.0 #### What's Changed - Update README.md to reflect latest version by [@​npwolf](https://togithub.com/npwolf) in [https://github.com/webfactory/ssh-agent/pull/196](https://togithub.com/webfactory/ssh-agent/pull/196) - Remove outdated claim from README by [@​benzado](https://togithub.com/benzado) in [https://github.com/webfactory/ssh-agent/pull/206](https://togithub.com/webfactory/ssh-agent/pull/206) - chore: update all versions of `actions/checkout` to v4 by [@​felix-seifert](https://togithub.com/felix-seifert) in [https://github.com/webfactory/ssh-agent/pull/199](https://togithub.com/webfactory/ssh-agent/pull/199) - bump to node20 by [@​archen](https://togithub.com/archen) in [https://github.com/webfactory/ssh-agent/pull/201](https://togithub.com/webfactory/ssh-agent/pull/201) #### New Contributors - [@​npwolf](https://togithub.com/npwolf) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/196](https://togithub.com/webfactory/ssh-agent/pull/196) - [@​benzado](https://togithub.com/benzado) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/206](https://togithub.com/webfactory/ssh-agent/pull/206) - [@​felix-seifert](https://togithub.com/felix-seifert) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/199](https://togithub.com/webfactory/ssh-agent/pull/199) - [@​archen](https://togithub.com/archen) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/201](https://togithub.com/webfactory/ssh-agent/pull/201) **Full Changelog**: webfactory/ssh-agent@v0.8.0...v0.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJnaXRodWItYWN0aW9ucyIsInJlbm92YXRlIl19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kdy1
referenced
this pull request
in swc-project/swc
Jul 22, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [balazsorban44/nissuer](https://togithub.com/balazsorban44/nissuer) | action | minor | `1.7.3` -> `1.10.0` | | [webfactory/ssh-agent](https://togithub.com/webfactory/ssh-agent) | action | minor | `v0.5.4` -> `v0.9.0` | --- ### Release Notes <details> <summary>balazsorban44/nissuer (balazsorban44/nissuer)</summary> ### [`v1.10.0`](https://togithub.com/balazsorban44/nissuer/releases/tag/1.10.0) [Compare Source](https://togithub.com/balazsorban44/nissuer/compare/1.9.3...1.10.0) **Full Changelog**: balazsorban44/nissuer@1.9.3...1.10.0 ### [`v1.9.3`](https://togithub.com/balazsorban44/nissuer/releases/tag/1.9.3) [Compare Source](https://togithub.com/balazsorban44/nissuer/compare/1.9.2...1.9.3) **Full Changelog**: balazsorban44/nissuer@1.9.2...1.9.3 ### [`v1.9.2`](https://togithub.com/balazsorban44/nissuer/releases/tag/1.9.2) [Compare Source](https://togithub.com/balazsorban44/nissuer/compare/1.9.1...1.9.2) **Full Changelog**: balazsorban44/nissuer@1.9.1...1.9.2 ### [`v1.9.1`](https://togithub.com/balazsorban44/nissuer/releases/tag/1.9.1) [Compare Source](https://togithub.com/balazsorban44/nissuer/compare/1.9.0...1.9.1) **Full Changelog**: balazsorban44/nissuer@1.9.0...1.9.1 ### [`v1.9.0`](https://togithub.com/balazsorban44/nissuer/releases/tag/1.9.0) [Compare Source](https://togithub.com/balazsorban44/nissuer/compare/1.8.2...1.9.0) **Full Changelog**: balazsorban44/nissuer@1.8.2...1.9.0 ### [`v1.8.2`](https://togithub.com/balazsorban44/nissuer/releases/tag/1.8.2) [Compare Source](https://togithub.com/balazsorban44/nissuer/compare/1.8.1...1.8.2) **Full Changelog**: balazsorban44/nissuer@1.8.1...1.8.2 ### [`v1.8.1`](https://togithub.com/balazsorban44/nissuer/releases/tag/1.8.1) [Compare Source](https://togithub.com/balazsorban44/nissuer/compare/1.8.0...1.8.1) Fix https://github.com/balazsorban44/nissuer/releases/tag/1.8.0 by actually shipping the built version ### [`v1.8.0`](https://togithub.com/balazsorban44/nissuer/releases/tag/1.8.0) [Compare Source](https://togithub.com/balazsorban44/nissuer/compare/1.7.3...1.8.0) #### Features - do not hide comments from organization members ([`2d5aa95`](https://togithub.com/balazsorban44/nissuer/commit/2d5aa95)) - add blocklist option ([`eb4bf4b`](https://togithub.com/balazsorban44/nissuer/commit/eb4bf4b)) - **docs:** update readme and action ([`6163c40`](https://togithub.com/balazsorban44/nissuer/commit/6163c40)) #### Other changes - bump dependencies ([`6114e48`](https://togithub.com/balazsorban44/nissuer/commit/6114e48)) </details> <details> <summary>webfactory/ssh-agent (webfactory/ssh-agent)</summary> ### [`v0.9.0`](https://togithub.com/webfactory/ssh-agent/releases/tag/v0.9.0): Update to `node20` [Compare Source](https://togithub.com/webfactory/ssh-agent/compare/v0.8.0...v0.9.0) This release updates the action to run on Node.js v20. When you're running on GitHub hosted runners, just go ahead and update. When you're using self-hosted runners, please make sure you have Node.js v20 installed before updating from `v0.8.0` to `v0.9.0` of this action. #### New Contributors - [@​npwolf](https://togithub.com/npwolf) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/196](https://togithub.com/webfactory/ssh-agent/pull/196) - [@​benzado](https://togithub.com/benzado) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/206](https://togithub.com/webfactory/ssh-agent/pull/206) - [@​felix-seifert](https://togithub.com/felix-seifert) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/199](https://togithub.com/webfactory/ssh-agent/pull/199) - [@​archen](https://togithub.com/archen) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/201](https://togithub.com/webfactory/ssh-agent/pull/201) **Full Changelog**: webfactory/ssh-agent@v0.8.0...v0.9.0 #### What's Changed - Update README.md to reflect latest version by [@​npwolf](https://togithub.com/npwolf) in [https://github.com/webfactory/ssh-agent/pull/196](https://togithub.com/webfactory/ssh-agent/pull/196) - Remove outdated claim from README by [@​benzado](https://togithub.com/benzado) in [https://github.com/webfactory/ssh-agent/pull/206](https://togithub.com/webfactory/ssh-agent/pull/206) - chore: update all versions of `actions/checkout` to v4 by [@​felix-seifert](https://togithub.com/felix-seifert) in [https://github.com/webfactory/ssh-agent/pull/199](https://togithub.com/webfactory/ssh-agent/pull/199) - bump to node20 by [@​archen](https://togithub.com/archen) in [https://github.com/webfactory/ssh-agent/pull/201](https://togithub.com/webfactory/ssh-agent/pull/201) #### New Contributors - [@​npwolf](https://togithub.com/npwolf) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/196](https://togithub.com/webfactory/ssh-agent/pull/196) - [@​benzado](https://togithub.com/benzado) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/206](https://togithub.com/webfactory/ssh-agent/pull/206) - [@​felix-seifert](https://togithub.com/felix-seifert) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/199](https://togithub.com/webfactory/ssh-agent/pull/199) - [@​archen](https://togithub.com/archen) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/201](https://togithub.com/webfactory/ssh-agent/pull/201) **Full Changelog**: webfactory/ssh-agent@v0.8.0...v0.9.0 ### [`v0.8.0`](https://togithub.com/webfactory/ssh-agent/releases/tag/v0.8.0): SSH host keys no longer managed – read below 👇 [Compare Source](https://togithub.com/webfactory/ssh-agent/compare/v0.7.0...v0.8.0) Starting with this release, this action no longer writes GitHub's SSH host keys into the `known_hosts` SSH config file upon start. GitHub changed their host keys on short notice this morning, see https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/. We took this as an opportunity to stop maintaining GH SSH keys in the code shipped with this action ([#​171](https://togithub.com/webfactory/ssh-agent/issues/171)). What you need to do: - On GitHub hosted runners, nothing. ✔︎ These runners ship with SSH host keys (for `github.com`) maintained by directly by GitHub. - On self-hosted runners, review and fix your SSH `known_hosts` file: - First, you'll find it bloated with redundant entries for `github.com`, as described in [#​106](https://togithub.com/webfactory/ssh-agent/issues/106). Remove these entries. - Review https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/. You probably removed the old (invalid) SSH key in the previous step. - Configure GitHub's current SSH keys as documented on https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/githubs-ssh-key-fingerprints - As long as versions before `v0.8.0` of this action here are run on the self-hosted runner, the old entries will come back. Keep an eye on it, possibly you'll have to rinse & repeat. ##### Other code changes in this release - Update to `actions/checkout@v3` by [@​mpdude](https://togithub.com/mpdude) in [https://github.com/webfactory/ssh-agent/pull/143](https://togithub.com/webfactory/ssh-agent/pull/143) - Allow the user to override the commands for `git`, `ssh-agent`, and `ssh-add` by [@​DilumAluthge](https://togithub.com/DilumAluthge) in [https://github.com/webfactory/ssh-agent/pull/154](https://togithub.com/webfactory/ssh-agent/pull/154) ##### New Contributors - [@​prhiggins](https://togithub.com/prhiggins) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/153](https://togithub.com/webfactory/ssh-agent/pull/153) - [@​kjarkur](https://togithub.com/kjarkur) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/147](https://togithub.com/webfactory/ssh-agent/pull/147) - [@​DilumAluthge](https://togithub.com/DilumAluthge) made their first contribution in [https://github.com/webfactory/ssh-agent/pull/154](https://togithub.com/webfactory/ssh-agent/pull/154) **Full Changelog**: webfactory/ssh-agent@v0.7.0...v0.8.0 ### [`v0.7.0`](https://togithub.com/webfactory/ssh-agent/blob/HEAD/CHANGELOG.md#v070-2022-10-19) [Compare Source](https://togithub.com/webfactory/ssh-agent/compare/v0.6.0...v0.7.0) ##### Added - Add the `log-public-key` input that can be used to turn off logging key identities ([#​122](https://togithub.com/webfactory/ssh-agent/issues/122)) ##### Fixed - Fix path to `git` binary on Windows, assuming GitHub-hosted runners ([#​136](https://togithub.com/webfactory/ssh-agent/issues/136), [#​137](https://togithub.com/webfactory/ssh-agent/issues/137)) - Fix a nonsensical log message ([#​139](https://togithub.com/webfactory/ssh-agent/issues/139)) ### [`v0.6.0`](https://togithub.com/webfactory/ssh-agent/blob/HEAD/CHANGELOG.md#v060-2022-10-19) [Compare Source](https://togithub.com/webfactory/ssh-agent/compare/v0.5.4...v0.6.0) ##### Changed - Update the version of Node used by the action from 12 to 16 (https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/swc-project/swc). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
JrGoodle
pushed a commit
to happybits/ssh-agent
that referenced
this pull request
Oct 9, 2024
Fix for deprecated node16 Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: webfactory/ssh-agent@v0.8.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ # Conflicts: # action.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for deprecated node16
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: webfactory/ssh-agent@v0.8.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/