Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: samples + mono repo + track changes #18

Merged
merged 33 commits into from
Jan 26, 2023
Merged

feat: samples + mono repo + track changes #18

merged 33 commits into from
Jan 26, 2023

Conversation

haohancom
Copy link

No description provided.

Copy link
Collaborator

@bbaldino bbaldino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does the packets name refer to?

@haohancom
Copy link
Author

@bbaldino sorry for late response, i missed your comment. it should be packages instead of packets , I've renamed them.

@haohancom haohancom marked this pull request as ready for review January 5, 2023 02:33
Copy link
Collaborator

@bbaldino bbaldino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine. But I know @arun3528 has some big changes pending...Arun do you want to get your stuff in first?

@arun3528
Copy link
Contributor

Is there a way to fix the issue with file renames they are showing up as new files

@haohancom
Copy link
Author

Is there a way to fix the issue with file renames they are showing up as new files

I'm not quite sure what you're referring to... @arun3528 could you say a little more detailed?

@arun3528
Copy link
Contributor

arun3528 commented Jan 16, 2023 via email

@arun3528 arun3528 changed the base branch from sample to main January 25, 2023 17:35
@arun3528 arun3528 changed the base branch from main to beta January 25, 2023 17:40
@arun3528 arun3528 changed the title chore: convert repo into mono one feat: samples + mono repo + track changes Jan 25, 2023
@arun3528 arun3528 force-pushed the mono branch 6 times, most recently from ff6b49f to 6c1c664 Compare January 26, 2023 22:18
@arun3528 arun3528 merged commit 4e9891a into beta Jan 26, 2023
github-actions bot pushed a commit that referenced this pull request Jan 27, 2023
# [1.4.0-beta.1](v1.3.0...v1.4.0-beta.1) (2023-01-27)

### Bug Fixes

* build only webrtc core on release ([6e4e702](6e4e702))
* move husky to root ([36c6562](36c6562))
* release script to not publish samples ([#24](#24)) ([42c2d5e](42c2d5e))
* revert the workspace usage in samples ([d04bc65](d04bc65))

### Features

* samples + mono repo + track changes ([#18](#18)) ([4e9891a](4e9891a))
@arun3528 arun3528 deleted the mono branch January 31, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants