Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contributor Guide #5045

Merged
merged 9 commits into from
Feb 23, 2020
Merged

Add Contributor Guide #5045

merged 9 commits into from
Feb 23, 2020

Conversation

christian-bromann
Copy link
Member

Proposed changes

This patch adds a contributor guide that should help people making their first contribution to the project. Compared to the CONTRIBUTING.md which is more like contributor documentation the guide should give more information about the process of contributing to the project without going into technical details or governance too much.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/technical-committee

@christian-bromann christian-bromann added PR: Docs 📝 PRs that contain changes to the documentation needs-review These Pull Requests require review from project members labels Feb 20, 2020
@christian-bromann christian-bromann requested a review from a team February 20, 2020 09:28
@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #5045 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5045      +/-   ##
==========================================
- Coverage    99.4%   99.39%   -0.01%     
==========================================
  Files         210      210              
  Lines        5510     5612     +102     
  Branches     1180     1211      +31     
==========================================
+ Hits         5477     5578     +101     
- Misses         30       31       +1     
  Partials        3        3
Impacted Files Coverage Δ
packages/wdio-cli/src/constants.js 80% <0%> (-8.89%) ⬇️
...kages/webdriverio/src/commands/element/addValue.js 100% <0%> (ø) ⬆️
packages/wdio-sauce-service/src/launcher.js 100% <0%> (ø) ⬆️
packages/wdio-runner/src/utils.js 100% <0%> (ø) ⬆️
packages/wdio-appium-service/src/launcher.js 100% <0%> (ø) ⬆️
...s/wdio-selenium-standalone-service/src/launcher.js 100% <0%> (ø) ⬆️
packages/wdio-testingbot-service/src/launcher.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e732235...1c15c22. Read the comment docs.

Copy link
Member

@erwinheitzman erwinheitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one suggestion, please let me know if we want to change this after which I will approve :)

@christian-bromann
Copy link
Member Author

@erwinheitzman updated docs and removed Chai.

Copy link
Member

@erwinheitzman erwinheitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@christian-bromann christian-bromann merged commit 0438219 into master Feb 23, 2020
@christian-bromann christian-bromann deleted the cb-contribute-page branch February 23, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review These Pull Requests require review from project members PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants