Performance improvements on element creation

[christian-bromann]

Proposed changes

I found this while investigating some performance issues: when we fetch a large amount of elements we run some unnecessary computation within a loop which can be easily refactored. The flame chart changes from:

to:

which is a small but not insignificant win 🎉

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Checklist

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

[codecov]

Codecov Report

Merging #4940 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4940      +/-   ##
==========================================
+ Coverage   99.42%   99.42%   +<.01%     
==========================================
  Files         210      210              
  Lines        5535     5608      +73     
  Branches     1211     1240      +29     
==========================================
+ Hits         5503     5576      +73     
  Misses         29       29              
  Partials        3        3

Impacted Files	Coverage Δ
packages/webdriverio/src/utils/getElementObject.js	97.87% <100%> (+0.04%)	⬆️
packages/webdriver/src/request.js	100% <0%> (ø)	⬆️
packages/wdio-runner/src/utils.js	100% <0%> (ø)	⬆️
packages/wdio-config/src/utils.js	100% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 808ba34...e1e3fee. Read the comment docs.

[gustavohenke]

which is a small but not insignificant win

I don't think it is a small one! The chart looks much cleaner now.

[christian-bromann]

@erwinheitzman I adjusted both implementations, anything left?

[erwinheitzman]

LGTM