Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WebdriverIOAsync namespace #4720

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Remove WebdriverIOAsync namespace #4720

merged 2 commits into from
Dec 16, 2019

Conversation

christian-bromann
Copy link
Member

Is your feature request related to a problem? Please describe.
I'd like to remove WebdriverIOAsync and replace it with WebdriverIO

Describe the solution you'd like

  • remove webdriverio.d.ts from webdriverio folder
  • rename webdriverio-v6.d.ts to webdriverio.d.ts
  • change any occurrences of WebdriverIOAsync to WebdriverIO

Additional context
#4706

@mgrybyk mgrybyk added the PR: Breaking Change 💥 PRs that contain breaking changes label Nov 2, 2019
@mgrybyk mgrybyk added this to the v6 milestone Nov 2, 2019
@mgrybyk mgrybyk mentioned this pull request Nov 2, 2019
Merged
7 tasks
@christian-bromann christian-bromann requested a review from a team December 16, 2019 00:07
@christian-bromann christian-bromann force-pushed the cb-get-rid-of-WebdriverIOAsync branch from c410ebf to 4c16201 Compare December 16, 2019 00:26
@codecov
Copy link

codecov bot commented Dec 16, 2019 •
edited
Loading

Codecov Report

Merging #4720 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4720   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files         209      209           
  Lines        5476     5476           
  Branches     1198     1198           
=======================================
  Hits         5443     5443           
  Misses         30       30           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92de2ed...fd26ee1. Read the comment docs.

@CrispusDH CrispusDH requested a review from mgrybyk December 16, 2019 06:21
mgrybyk
mgrybyk reviewed Dec 16, 2019
View reviewed changes
Copy link
Member

@mgrybyk mgrybyk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve it because it's originally my cr, can be merged! 👍

@christian-bromann christian-bromann merged commit b3db259 into master Dec 16, 2019
@christian-bromann christian-bromann deleted the cb-get-rid-of-WebdriverIOAsync branch December 16, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrybyk mgrybyk mgrybyk left review comments

Assignees
No one assigned
Labels
PR: Breaking Change 💥 PRs that contain breaking changes
Projects
None yet
Milestone
v6
Development

Successfully merging this pull request may close these issues.
2 participants
@christian-bromann @mgrybyk