Skip to content

Commit

Permalink
fix TS issues
Browse files Browse the repository at this point in the history
  • Loading branch information
christian-bromann committed Nov 30, 2020
1 parent 43e8729 commit e7b2e0f
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion packages/devtools/src/devtoolsdriver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export default class DevToolsDriver {
if (err.message.includes('most likely because of a navigation')) {
log.debug('Command failed due to unfinished page transition, retrying...')
const page = self.getPageHandle()
await new Promise((resolve, reject) => {
await new Promise<void>((resolve, reject) => {
const pageloadTimeout = setTimeout(
() => reject(new Error('page load timeout')),
self.timeouts.get('pageLoad'))
Expand Down
2 changes: 1 addition & 1 deletion packages/wdio-devtools-service/src/gatherer/trace.ts
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ export default class TraceGatherer extends EventEmitter {
}
const networkStatusMonitor = this._networkStatusMonitor

const promise = new Promise((resolve) => {
const promise = new Promise<void>((resolve) => {
const onIdle = () => {
// eslint-disable-next-line no-use-before-define
networkStatusMonitor.once('network-2-busy', onBusy)
Expand Down
2 changes: 1 addition & 1 deletion packages/wdio-devtools-service/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ export default class DevToolsService implements WebdriverIO.ServiceInstance {
})
})

return new Promise((resolve) => {
return new Promise<void>((resolve) => {
log.info(`Wait until tracing for command ${commandName} finishes`)

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/wdio-local-runner/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export default class LocalRunner {
worker.postMessage('endSession', payload)
}

return new Promise((resolve) => {
return new Promise<void>((resolve) => {
const timeout = setTimeout(resolve, SHUTDOWN_TIMEOUT)
const interval = setInterval(() => {
const busyWorker = Object.entries(this.workerPool)
Expand Down
4 changes: 2 additions & 2 deletions packages/wdio-logger/src/node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -134,15 +134,15 @@ export default function getLogger (name: string) {
* Wait for writable stream to be flushed.
* Calling this prevents part of the logs in the very env to be lost.
*/
getLogger.waitForBuffer = async () => new Promise(resolve => {
getLogger.waitForBuffer = async () => new Promise<void>(resolve => {
// @ts-ignore
if (logFile && Array.isArray(logFile.writableBuffer) && logFile.writableBuffer.length !== 0) {
return setTimeout(async () => {
await getLogger.waitForBuffer()
resolve()
}, 20)
}
resolve(true)
resolve()
})
getLogger.setLevel = (name: string, level: log.LogLevelDesc) => loggers[name].setLevel(level)
getLogger.clearLogger = () => {
Expand Down
4 changes: 2 additions & 2 deletions packages/wdio-shared-store-service/src/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ const startServer = () => new Promise((resolve, reject) => {
})
})

const stopServer = () => new Promise((resolve) => {
const stopServer = () => new Promise<void>((resolve) => {
if (app.server.close) {
return app.server.close(resolve)
return app.server.close(() => resolve())
}
resolve()
})
Expand Down
2 changes: 1 addition & 1 deletion packages/webdriverio/src/commands/browser/debug.ts
Original file line number Diff line number Diff line change
Expand Up @@ -113,5 +113,5 @@ export default function debug(
}
})

return new Promise((resolve) => (commandResolve = resolve))
return new Promise<void>((resolve) => (commandResolve = resolve))
}

0 comments on commit e7b2e0f

Please sign in to comment.