Overwrite sync expect fn with expectAsync #545
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Jasmine our async matchers aren't working because the expected promise is never resolved and results in errors like these:
Therefor let's just overwrite the async expect function with this one. The only downside is that the following matchers aren't available anymore:
toBeNegativeInfinity
,toBePositiveInfinity
,toHaveBeenCalledBefore
,toThrowMatching
,withContext
,toHaveSize
,toHaveClass
. Given they aren't really useful in the e2e context I believe this is the best way to resolve the overall confusion.