Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite sync expect fn with expectAsync #545

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

christian-bromann
Copy link
Member

In Jasmine our async matchers aren't working because the expected promise is never resolved and results in errors like these:

Error: Expected [object Promise] to be existing.
    at <Jasmine>
    at ...

Therefor let's just overwrite the async expect function with this one. The only downside is that the following matchers aren't available anymore: toBeNegativeInfinity, toBePositiveInfinity, toHaveBeenCalledBefore, toThrowMatching, withContext, toHaveSize, toHaveClass. Given they aren't really useful in the e2e context I believe this is the best way to resolve the overall confusion.

@christian-bromann
Copy link
Member Author

I will go ahead and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant