Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase code coverage #478

Merged
merged 13 commits into from
Jul 12, 2021
Merged

Increase code coverage #478

merged 13 commits into from
Jul 12, 2021

Conversation

TuxedoFish
Copy link
Contributor

  • adds util/ test files (Hitting untested parts and still needs future work)
  • improve toHaveElementProperty tests
  • Change elementsUtil forEach to for loop as seemed to not be functioning correctly
  • update options test to increase coverage
  • remove jasmineUtil from test coverage since it was a file extracted out of jasmine 2.5.2 and seems to thererfore be outside of scope of increasing the coverage for the repo, this was my thinking but what do you think?

All these things considered statement coverage is now just over 99% but branch coverage needs improvement and there are still missing test cases I think

christian-bromann
christian-bromann reviewed Jul 1, 2021
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Thanks a lot. Some minor comments.

Do you know why some of the tests are failing?`

src/util/elementsUtil.ts Outdated Show resolved Hide resolved
test/util/executeCommand.test.ts Outdated Show resolved Hide resolved
test/util/executeCommand.test.ts Outdated Show resolved Hide resolved
test/util/formatMessage.test.ts Outdated Show resolved Hide resolved
test/util/formatMessage.test.ts Outdated Show resolved Hide resolved
test/util/formatMessage.test.ts Outdated Show resolved Hide resolved
test/util/formatMessage.test.ts Outdated Show resolved Hide resolved
test/util/formatMessage.test.ts Outdated Show resolved Hide resolved
test/util/formatMessage.test.ts Outdated Show resolved Hide resolved
@TuxedoFish
Copy link
Contributor Author

Ahh oversight from me, I was running the tests in isolation and completely missed this!! Thanks for the comments I will fix those things and get the tests passing cheers!

christian-bromann
christian-bromann approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect, thanks so much 🙏

@christian-bromann christian-bromann merged commit 6f0f648 into webdriverio:main Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TuxedoFish @christian-bromann